Add PathSegmentsMut::finish #380
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 tasks
Member
|
Thank you for the PR. The signature change for existing method is a breaking change and can not be done in rust-url 1.x. I’ve added this to #463. |
Author
|
This PR is from 2017, I thought you didn't needed theses changes anymore. Do I need to do something to make it compatible with version 2.0? |
Contributor
|
☔ The latest upstream changes (presumably #517) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved the issue #363, added some documentation and a unit test for what the issue author wanted to do.
I was able to resolve this issue only by changing &mut PathSegmentsMut to mut PathSegmentsMut, which is quite a huge change.
This change is