[idna] Add unit tests for punycode prefix edge cases #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps with answering question asked in servo#373 The test invariants here are based on and checked against: * Processing Step 4 of UTS#46 (<http://www.unicode.org/reports/tr46/#ProcessingStepPunycode>) * 6.2 Decoding procedure of Punycode RFC. (<https://ietf.org/rfc/rfc3492.txt>)
Contributor
|
☔ The latest upstream changes (presumably #517) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
This would be good to have, though it'll have to be rebased on current master. |
Contributor
|
I rebased this, but the tests for |
|
The reason they don't pass (i.e., no longer expect an error) is probably because CheckHyphens is set to false. Having said that, it's pretty clear the URL Standard algorithm for IDNA has issues as well as browsers are not fully aligned with it: https://github.com/whatwg/url/labels/topic%3A%20idna. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with answering question asked in
#373
The test invariants here are based on and checked against:
Processing Step 4 of UTS#46
(http://www.unicode.org/reports/tr46/#ProcessingStepPunycode)
6.2 Decoding procedure of Punycode RFC.
(https://ietf.org/rfc/rfc3492.txt)
This change is