set_scheme should fail if url has host or port #366
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmccombs
force-pushed
the
file_scheme_change
branch
from
e30bcfe to
b909104
Compare
tmccombs
force-pushed
the
file_scheme_change
branch
from
b909104 to
82f06b6
Compare
tmccombs
commented
Jun 18, 2017
| Url::parse("mailto:").unwrap().cannot_be_a_base(); | ||
| } | ||
|
|
||
| #[test] |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if this is the best place to put the unit test.
Member
|
Thank you for the PR. The code looks ok at first glance, but this may not be the right change to. Let’s discuss in #278. |
Contributor
|
☔ The latest upstream changes (presumably #517) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
The test proposed in #278 seems to pass now, so I don't think we need this anymore. Let me know if you have a different opinion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #278
This change is