Skip to content

Conversation

@Shiftas
Copy link
Contributor

@Shiftas Shiftas commented Sep 27, 2016

Implementation of wiki box parser.
Only for works for evaluated pages.

Feel free to decline it if you feel it is too incomplete to be added, as not all fields from wiki box is parsed and I do not have tests for this.

Implementation of wiki box parser.
Only for works for evaluated pages.
@gsouf
Copy link
Member

gsouf commented Sep 29, 2016

Hi, I'll review this asap

@gsouf
Copy link
Member

gsouf commented Sep 30, 2016

Thanks for the contribution it's very appreciated.

I need to think about it, because I'm not sure if wiki parser support is very helpful for the moment because it will add a lot of maintenance for a side part of the library. The main goal is to parse natural result, and as a second goal adwords result, I still need some work to make that stable.

Well, we could offer it as a plugin, or leave it in development stage in its own branch until I feel it's ok to merge it. I need to think for the best solution. In any cases I have a lot of improvement and a few refactoring to bring before.

What is your use case of the wikiboxes?

@Shiftas
Copy link
Contributor Author

Shiftas commented Oct 3, 2016

Well, i need to get info out of it, like title, description, map details etc. I later use them for some data processing. And as I said, its just a suggestion, so if you feel it does not belong here, just reject it. I have already implemented it outside of this library, as it is quite easy to extend without actually changing it.

@thebennos
Copy link

detecting of wikiboxes would be nice.
+1 for this pull request.

gsouf added a commit that referenced this pull request May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants