Skip to content

Fix: Update ConditionalSink expression syntax in sample app - #470

Merged
nblumhardt merged 1 commit into
serilog:devfrom
gyurebalint:fix-conditional-sink-syntax
Apr 7, 2026
Merged

Fix: Update ConditionalSink expression syntax in sample app#470
nblumhardt merged 1 commit into
serilog:devfrom
gyurebalint:fix-conditional-sink-syntax

Conversation

@gyurebalint

Copy link
Copy Markdown
Contributor

Description

This PR updates the WriteTo:ConditionalSink expression in the sample application's appsettings.json to use the current CLEF syntax.

The previous syntax (@Level) was outdated and prevented the conditional sink from functioning as intended when users ran the sample. It has been updated to the correct syntax (@l) as documented in the updated Serilog.Expressions package.

Fixes #337

Testing Performed

  • Ran the sample application locally using the .NET CLI.
  • Verified that the conditional sink successfully catches the Error logs and writes them to the %TEMP%/Logs/serilog-configuration-sample-errors.txt file.

@nblumhardt nblumhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nblumhardt
nblumhardt merged commit 11dcbc9 into serilog:dev Apr 7, 2026
1 check passed
@nblumhardt nblumhardt mentioned this pull request Apr 30, 2026
This was referenced Jun 15, 2026
SonnyRR pushed a commit to SonnyRR/stacked-deck-templates that referenced this pull request Jun 15, 2026
Updated
[Serilog.Settings.Configuration](https://github.com/serilog/serilog-settings-configuration)
from 10.0.0 to 10.0.1.

<details>
<summary>Release notes</summary>

_Sourced from [Serilog.Settings.Configuration's
releases](https://github.com/serilog/serilog-settings-configuration/releases)._

## 10.0.1

## What's Changed
* Support LevelAlias names in configuration parsing by @​mohammed-saalim
in serilog/serilog-settings-configuration#465
* Fix: Update ConditionalSink expression syntax in sample app by
@​gyurebalint in
serilog/serilog-settings-configuration#470
* issue-468: Fix empty/whitespace string converting to array type by
@​gyurebalint-CID in
serilog/serilog-settings-configuration#469
* Add WriteTo.FallbackChain and WriteTo.Fallible support in
configuration by @​ArieGato in
serilog/serilog-settings-configuration#474
* Fix/issue 441 by @​gyurebalint in
serilog/serilog-settings-configuration#471
* Support C# 13 params collections (IEnumerable<T>, List<T>) by
@​gyurebalint in
serilog/serilog-settings-configuration#478

## New Contributors
* @​mohammed-saalim made their first contribution in
serilog/serilog-settings-configuration#465
* @​gyurebalint made their first contribution in
serilog/serilog-settings-configuration#470
* @​gyurebalint-CID made their first contribution in
serilog/serilog-settings-configuration#469
* @​ArieGato made their first contribution in
serilog/serilog-settings-configuration#474

**Full Changelog**:
serilog/serilog-settings-configuration@v10.0.0...v10.0.1

Commits viewable in [compare
view](serilog/serilog-settings-configuration@v10.0.0...v10.0.1).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Serilog.Settings.Configuration&package-manager=nuget&previous-version=10.0.0&new-version=10.0.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
tetsuo13 pushed a commit to tetsuo13/TeamsStatusPub that referenced this pull request Jul 17, 2026
Updated [Serilog](https://github.com/serilog/serilog) from 4.3.1 to
4.4.0.

<details>
<summary>Release notes</summary>

_Sourced from [Serilog's
releases](https://github.com/serilog/serilog/releases)._

## 4.4.0

## What's Changed
* Emit SelfLog warning when extra arguments are provided by @​matantsach
in serilog/serilog#2222
* dont WriteQuotedJsonString for null by @​SimonCropp in
serilog/serilog#2216
* Pin System.Security.Cryptography.Xml to 8.0.3 in tests by @​ArieGato
in serilog/serilog#2232
* Route optional interfaces through OptionalInterfaceForwardingSink for
restricted sinks by @​ArieGato in
serilog/serilog#2234
* `SelfMetrics` by @​nblumhardt in
serilog/serilog#2237

## New Contributors
* @​matantsach made their first contribution in
serilog/serilog#2222
* @​ArieGato made their first contribution in
serilog/serilog#2232

**Full Changelog**:
serilog/serilog@v4.3.1...v4.4.0

Commits viewable in [compare
view](serilog/serilog@v4.3.1...v4.4.0).
</details>

Updated
[Serilog.Settings.Configuration](https://github.com/serilog/serilog-settings-configuration)
from 10.0.0 to 10.0.1.

<details>
<summary>Release notes</summary>

_Sourced from [Serilog.Settings.Configuration's
releases](https://github.com/serilog/serilog-settings-configuration/releases)._

## 10.0.1

## What's Changed
* Support LevelAlias names in configuration parsing by @​mohammed-saalim
in serilog/serilog-settings-configuration#465
* Fix: Update ConditionalSink expression syntax in sample app by
@​gyurebalint in
serilog/serilog-settings-configuration#470
* issue-468: Fix empty/whitespace string converting to array type by
@​gyurebalint-CID in
serilog/serilog-settings-configuration#469
* Add WriteTo.FallbackChain and WriteTo.Fallible support in
configuration by @​ArieGato in
serilog/serilog-settings-configuration#474
* Fix/issue 441 by @​gyurebalint in
serilog/serilog-settings-configuration#471
* Support C# 13 params collections (IEnumerable<T>, List<T>) by
@​gyurebalint in
serilog/serilog-settings-configuration#478

## New Contributors
* @​mohammed-saalim made their first contribution in
serilog/serilog-settings-configuration#465
* @​gyurebalint made their first contribution in
serilog/serilog-settings-configuration#470
* @​gyurebalint-CID made their first contribution in
serilog/serilog-settings-configuration#469
* @​ArieGato made their first contribution in
serilog/serilog-settings-configuration#474

**Full Changelog**:
serilog/serilog-settings-configuration@v10.0.0...v10.0.1

Commits viewable in [compare
view](serilog/serilog-settings-configuration@v10.0.0...v10.0.1).
</details>

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WriteTo:ConditionalSink does not work in sample application

2 participants