Skip to content

feat: add query parameters management#198

Merged
followynne merged 14 commits intoserilog-contrib:masterfrom
followynne:feat/add-query-parameters
May 3, 2026
Merged

feat: add query parameters management#198
followynne merged 14 commits intoserilog-contrib:masterfrom
followynne:feat/add-query-parameters

Conversation

@followynne
Copy link
Copy Markdown
Member

The changes I made were (#192):

instead of simple query-string parse/set, I changed the flow the application uses to manage the search state:
when a value changes, the URL is updated and the app reflects it in its internal state (and viceversa)
source of truth becomes the URL
URL updates and is included in the browser history (moving back and forth the browser history is reflected in the parameters and in the application)
I added a table-key set on query completion (it should fix #195!)

@followynne followynne linked an issue Apr 26, 2026 that may be closed by this pull request
@followynne
Copy link
Copy Markdown
Member Author

Hi @mo-esmp
PR is ready for review, if you can take a look and comment/approve it it would be great!
as soon as it's merged together with the .NET10 migration, I'll open the last one with node upgrades, before creating a beta version to test the new feature out.

@sommmen I'll tag you as soon as I put out the beta v, to let you provide a feedback on the result :)

@followynne followynne requested a review from mo-esmp May 2, 2026 15:10
@followynne followynne merged commit 0303049 into serilog-contrib:master May 3, 2026
1 of 2 checks passed
@followynne followynne deleted the feat/add-query-parameters branch May 3, 2026 11:17
@sommmen
Copy link
Copy Markdown
Contributor

sommmen commented May 4, 2026

Hi @mo-esmp PR is ready for review, if you can take a look and comment/approve it it would be great! as soon as it's merged together with the .NET10 migration, I'll open the last one with node upgrades, before creating a beta version to test the new feature out.

@sommmen I'll tag you as soon as I put out the beta v, to let you provide a feedback on the result :)

Looks great - im not on .net 10 yet so idk if i can get to testing soonish but ill see.
For your reference, in our own app we do roughly the same but we'd have a RequestOptions { page: .., perPage: ..., filters: }.
We bind directly on the request options from our view, but for filters we usually have an intermediate field on the component.

Then just before load is called we call 'updateRequestOptions' - it updates the requestoptions (intemediate field -> req. options) it then passes this to apiservice.getCollection(opt); which flows to the backend. Then the query params get updated also.

that way the request to the api is always reflected in the url instead of the frontend state. The solution as-is also works fine ofcourse.

@followynne
Copy link
Copy Markdown
Member Author

@sommmen I think I get your point, in this case I choose to plug this behavior in the client side infrastructure, we can later review it for improvement :)

BTW, the new version will be published for NET8&10, I'm just removing NET6 support to follow NET release cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto select a table? Query parameters for the filtervalues

4 participants