-
Notifications
You must be signed in to change notification settings - Fork 41
~fix tenant regex validation #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
~fix tenant regex validation #304
Conversation
+add method to set defaultrequestheader +add testcases
test/Serilog.Sinks.Grafana.Loki.Tests/HttpClientsTests/BaseLokiHttpClientTests.cs
Outdated
Show resolved
Hide resolved
|
Hey @smolo-de, Thank you a lot for the contribution. Have 2 more questions:
|
Regarding the first point, I will take another look at it and correct it. The new function is intended to serve as a backup and supplement in case further header information is required. For example, there is also “X-Loki-Actor-Path,” which is not currently implemented. If someone needs the option to override the headers, they could do so themselves in an emergency! |
~ change testcases to inlinedata
|
@smolo-de sorry for the delay. It looks like pipelines are failing due to violating StyleCop rules. Can you pls have a look, so we can merge it? Thanks! |
|
@smolo-de Any progress here? |
|
Released in v8.3.2 |
~bugfix for tenant regex validation
+add testcases
+add method to set defaultrequestheaders