Skip to content

Building against NW.js headers#1461

Merged
reconbot merged 1 commit into
serialport:masterfrom
saboya:node-webkit
Feb 3, 2018
Merged

Building against NW.js headers#1461
reconbot merged 1 commit into
serialport:masterfrom
saboya:node-webkit

Conversation

@saboya

@saboya saboya commented Feb 2, 2018

Copy link
Copy Markdown
Contributor

NW.js support was recently added to prebuild:

electron/node-abi#34
prebuild/prebuild#203

This PR bumps the minimal prebuild version to 7.4.0 to ensure NW.js support, and updates the README with NW.js build info.

@reconbot

reconbot commented Feb 3, 2018

Copy link
Copy Markdown
Member

This is great

@reconbot reconbot merged commit 672c198 into serialport:master Feb 3, 2018
@saboya saboya deleted the node-webkit branch February 7, 2018 12:00
IvanSanchez pushed a commit to NordicPlayground/node-serialport that referenced this pull request Feb 27, 2018
oteku pushed a commit to Cutii/node-serialport that referenced this pull request Apr 9, 2018
reconbot pushed a commit that referenced this pull request Jul 24, 2018
@lock lock Bot locked as resolved and limited conversation to collaborators Aug 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants