Increase dependency options#58
Merged
seregazhuk merged 1 commit intoDec 7, 2019
Merged
Conversation
mmoreram
force-pushed
the
feature/increased-tests-and-relaxed-dependencies
branch
4 times, most recently
from
e428884 to
5e2e86c
Compare
seregazhuk
approved these changes
Dec 6, 2019
Owner
seregazhuk
left a comment
seregazhuk
left a comment
There was a problem hiding this comment.
@mmoreram Thank you for PR!
Just one little fix and I'll merge it 👍
| "ext-json": "*", | ||
| "ext-pcntl": "*", | ||
| "react/stream": "^1.0.0", | ||
| "Symfony/finder": "^4.3 || ^5.0", |
Owner
There was a problem hiding this comment.
It works, but I think it should be lower-case.
- Improves test document
+ PHP7.4
+ Lowest dependencies
+ Highest dependencies
- Finder is required by some other libraries, and in lowest version of
dependencies, the librarie goes to 2.7. We have forced the library
to have a minimum dependency of ^4.3
mmoreram
force-pushed
the
feature/increased-tests-and-relaxed-dependencies
branch
from
5e2e86c to
678f954
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves test document
Finder is required by some other libraries, and in lowest version of
dependencies, the library goes to 2.7. We have forced the library
to have a minimum dependency of ^4.3