List errors that occured while deserializing an untagged enum #3003
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puts #773 back on the table. Ran into the issue recently and seems like changes to the code made it a lot easier to fix. This is a naive attempt to create discussion on the topic.
The test changes are as follows:
The error before being:
Obviously there is a lot to discuss. I wanted to filter the errors to only output error message that came from deeper in the code (filter out structural issues in the enum itself as they could arguably be obvious), and the TODO message seem to imply it was done for toml (?) but this is out of my ability range as I am new to this codebase.
Previous works include #1544, which feature-gate the change, which could also be implemented here.