Skip to content

Implement expansion tests #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dtolnay merged 4 commits into from
Nov 25, 2019
Merged

Implement expansion tests #1662

dtolnay merged 4 commits into from
Nov 25, 2019

Conversation

@eupn
Copy link
Contributor

@eupn eupn commented Oct 31, 2019 •
edited
Loading

Related to #1117.

This PR implements serde's #[derive(Serialize, Deserialize)] macros expansion tests using macrotest.

To pass CI it requires cargo expand and rustfmt to be available.

dtolnay
dtolnay reviewed Nov 2, 2019
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eupn eupn requested a review from dtolnay November 4, 2019 06:16
@eupn
Copy link
Contributor Author

eupn commented Nov 10, 2019

@dtolnay ping

dtolnay
dtolnay approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit bcaebdb into serde-rs:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eupn @dtolnay