Skip to content

v3.20/ros/noetic/ros-noetic-roslint: fix E231 false-positive in python fstring#951

Merged
at-wat merged 6 commits intomasterfrom
v3.20-noetic-roslint/fix-E231-in-fstring
Jun 4, 2024
Merged

v3.20/ros/noetic/ros-noetic-roslint: fix E231 false-positive in python fstring#951
at-wat merged 6 commits intomasterfrom
v3.20-noetic-roslint/fix-E231-in-fstring

Conversation

@at-wat
Copy link
Copy Markdown
Member

@at-wat at-wat commented Jun 4, 2024

Port the fix from PyCQA/pycodestyle#1148
and enable unused test in ros/roslint.

Before porting the fix:

https://github.com/seqsense/aports-ros-experimental/runs/25776861476

Built target clean_test_results_roslint
tests/clean1.py:26:19: E231 missing whitespace after ':'
make[7]: *** [CMakeFiles/roslint_roslint.dir/build.make:71: roslint_roslint] Error 1

After porting the fix:

https://github.com/seqsense/aports-ros-experimental/pull/951/checks?check_run_id=25776986808
No error

@at-wat at-wat self-assigned this Jun 4, 2024
@at-wat at-wat requested a review from f-fl0 June 4, 2024 09:09
Copy link
Copy Markdown
Contributor

@f-fl0 f-fl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@at-wat at-wat merged commit 0f83281 into master Jun 4, 2024
@at-wat at-wat deleted the v3.20-noetic-roslint/fix-E231-in-fstring branch June 4, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants