docs: Remove Seqera's registry from values.yaml and point to vendoring instructions DEVOPS-966 #30
Conversation
|
JIRA ISSUE: DEVOPS-966 |
| name: release-name-platform-backend | ||
| - configMapRef: | ||
| name: release-name-platform-shared-backend-cron | ||
| image: cr.seqera.io/private/nf-tower-enterprise/backend:v9.9.9 |
There was a problem hiding this comment.
where are these tests run. will the registry need to substituted here by the users?
There was a problem hiding this comment.
where are these tests run.
these are snapshots of the rendered manifests, produced by https://github.com/helm-unittest/helm-unittest/?tab=readme-ov-file#snapshot-testing
they are executed at each commit by pre-commit and are also executed by the GHA that packages the chart as a requirement
more details on how to collaborate on the chart and how to run them is in the CONTRIBUTING readme
will the registry need to substituted here by the users?
yes, that's the idea of this PR and of the prerequisite page added to our docs with instructions for customers on how to vendor the seqera platform images: see PR seqeralabs/docs#911
bebosudo
deleted the
chiusole/empty-registry-and-add-vendoring-instructions
branch
@gavinelder now the chart comes without any reference to cr.seqera.io anymore, and in the README I point users to the new vendoring instructions: seqeralabs/docs#911 (I'll wait to merge this until that PR is merged)
I'm not sure whether we want to require users to pass a registry value and
failin the helm chart if they don't, since there may be some corner cases where that may not be required, e.g. container images somehow "found" or rebuilt on the k8s server. Opinions?