fix a compatability issue with Valkey 8 forward#300
Merged
CorbinGraham merged 2 commits intomasterfrom Jan 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valkey 8 introduced a change to an error message that created an incompatibility when trying to catch the error that we need to reload the Lua scripts for. Valkey opted not to revert these changes even though it created issues with external dependencies like Qless.
This change simply adds another match text for the error message to regain compatibility.
Issue link from Valkey: valkey-io/valkey#1537
Code change in Valkey: https://github.com/valkey-io/valkey/pull/617/changes#diff-1abc5651133d108c0c420d9411925373c711133e7748d9e4f4c97d5fb543fdd9R1819