Skip to content

Add missing type hints and make them consistent #131

@abdelrahman725

Description

@abdelrahman725
  1. It would be nice to add the missing type hints to instnace attributes and functions return type. This improves readability and development. It will also avoid the vague Unknown type when hovering over code inside code editors like VS code.

  2. Consistnecy: some annotations are not consistent, mixing built-in generics with typing generics (e.g., Dict and dict). Since Experanto supports Python>=3.9 (as defined in pyproject.toml), I believe it will be safe to migrate to built-in types.

I've already started working on this, but I'm opening this issue first to follow what Polina suggested in GSoC forum. I will open a PR once you approve

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions