-
Notifications
You must be signed in to change notification settings - Fork 143
[CLNP-6892][fix]: Fix search result click not triggering bounce animation #1422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f5df1f9
[fix]: Fix search result click not triggering bounce animation
sf-tyler-jeong f15d983
fix: replace void with bare expression to satisfy no-void lint rule
sf-tyler-jeong 9a8bcf7
fix: cast querySelector to HTMLElement for offsetHeight access
sf-tyler-jeong eec9426
[fix][CLNP-6892] Fix search result click not triggering bounce animation
sf-tyler-jeong 2e3a135
[fix][CLNP-6892] Handle thread parent jump when startingPoint is null
sf-tyler-jeong 17109ad
[fix][CLNP-6892] Address review feedback for bounce animation
sf-tyler-jeong cc87b64
Merge branch 'main' into fix/clnp-6892
sf-tyler-jeong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fallback으로 cleanup이 되는 부분이 필요가 없을까요? Uikit이 custom render를 제공하고 있어서, 정확한 루트로 진행이 안 될 수도 있습니다. fallback clean up이 가능하다면 같이 있으면 좋을 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
말씀하신 대로
bouncekeyframe 이 디센던트.sendbird-message-content에 걸려 있어서 customrenderMessage결과물에 그 클래스가 없으면onAnimationEnd가 발화되지 않아 animation state 가 stuck 되는 회귀가 있었습니다.최신 커밋에서 fallback
setTimeout을 추가해 CSS animation duration(1s) + 버퍼 후 강제 정리하도록 수정했습니다.fallbackTimerRef로 timer 추적 →handleAnimationEnd가 정상 발화하면 clear 해서 이중 정리 방지[isAnimationTarget]만 의존하도록 안정화 → 부모가onMessageAnimated를 memoize 하지 않아도 fallback timer 가 조기 clear 되지 않게 처리했습니다감사합니다!