Skip to content

Conversation

@semuadmin
Copy link
Contributor

pyubx2 Pull Request Template

Description

FIXES:

  1. Fix SEC-SIG v2 payload definition (repeating group omitted).

CHANGES:

  1. Minor changes to dop2str() helper method.
  2. Minimum pyrtcm version updated to 1.1.8 (includes some exception handling enhancements).

Fixes #186

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

If you're adding new UBX message definitions for Generation 9+ devices, please check for any corresponding configuration database updates (ubxtypes_configdb.py).

  • test_stream.py updated with correct SEC-SIG definition

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.MD).
  • I have performed a self-review of my own code.
  • (if appropriate) I have cited my u-blox documentation source(s).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added this to the RC 1.2.54 milestone Jul 21, 2025
@semuadmin semuadmin requested a review from a team July 21, 2025 10:23
@semuadmin semuadmin self-assigned this Jul 21, 2025
@semuadmin semuadmin added bug Something isn't working enhancement New feature or request labels Jul 21, 2025
@semuadmin semuadmin marked this pull request as draft July 21, 2025 10:23
@semuadmin semuadmin marked this pull request as ready for review July 21, 2025 10:32
@semuadmin semuadmin merged commit a085e41 into master Jul 21, 2025
@semuadmin semuadmin deleted the RC-1.2.54 branch July 21, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UBX-SEC-SIG is missing the repeated group fields

2 participants