Skip to content

Conversation

@pieterocp
Copy link

Ended up reading through the repo since I was having issues with change_in, it was an issue on my end since I didn't realise that all jobs will run if the files change, so read through changein/function.go and nosey me sees a typo, so trawled through and addressed them.

Nothing major, just internal changes, docs improvements, error messages made clearer.

@pieterocp
Copy link
Author

Any semaphore Devs able to give this a review?

@pieterocp
Copy link
Author

Thanks for addressing the typo in #55, rebased with master. Any reviewers?

@hamir-suspect
Copy link

/sem-approve

@hamir-suspect
Copy link

@pieterocp would you be willing to update the Makefile as well to use the publicly available security-toolbox like here: https://github.com/semaphoreci/cli/blob/master/Makefile#L9

since this has been migrated, and now the private project doesn't exist

(based on PR feedback + https://github.com/semaphoreci/cli/pull/239/files)
@pieterocp
Copy link
Author

@pieterocp would you be willing to update the Makefile as well to use the publicly available security-toolbox like here: https://github.com/semaphoreci/cli/blob/master/Makefile#L9

@hamir-suspect no problem at all, as far as I am aware, made the changes with 81c5aec 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants