Add shell completion for sem context
#238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/sem-approve |
lucaspin
approved these changes
Jul 9, 2025
Contributor
|
@danudey thanks for the PR, everything looks good. However, you're gonna need to update your branch with master, to pick up this change. With that change, your CI build should pass. |
1. Add `contextValidArgs()` function to complete a list of contexts and their endpoints 2. Set the `context` subcommand's `ValidArgsFunction` to `contextValidArgs()`
danudey
force-pushed
the
add-sem-context-completion
branch
from
d49fd4c to
ef0bec0
Compare
Contributor
Author
@lucaspin Rebased and pushed, it's all approved now but it looks like CI didn't run? Or re-run? |
Contributor
|
/sem-approve |
Contributor
|
All good now. Thanks again @danudey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple patch to fix a pet peeve of mine. Does the following:
ContextList()->ContextNameList(); now more accurately describes what it does in the context (ha!) of the next changeContextList()to return list of context objects rather than just namessem contextby creating aValidArgsFunctionsem contextbut we don't have any contexts configuredNote: We bump
cobrain this PR, but I looked through the changelogs between this version (1.9.1) and the previous (1.7.0) and there are no backwards-incompatible changes anywhere that I saw. Bump was for two reasons: