[SELF-676] feat: upgrade React Native from 0.75.4 to 0.76.9 #943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughRaised platform and dependency versions, added an iOS pod-install recovery script for Hermes cache issues, re-exported proving utilities from common, removed Rust Android integration and fling gesture handling, and introduced concurrency, caching, and workspace-resolution improvements across CI workflows. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant GH as GitHub Actions (iOS Pod step)
participant Shell as Shell
participant Bundler as Bundler
participant Script as pod-install-with-cache-fix.sh
participant CocoaPods as CocoaPods
GH->>Shell: cd app/ios
GH->>Bundler: bundle install (uses app/ios vendor/bundle)
GH->>Script: bundle exec bash scripts/pod-install-with-cache-fix.sh
activate Script
Script->>CocoaPods: pod cache clean --all (best-effort)
Script->>Shell: rm -rf ~/Library/Caches/CocoaPods (ignore errors)
Script->>CocoaPods: pod install
alt pod install fails
Script->>CocoaPods: pod update hermes-engine --no-repo-update
Script->>CocoaPods: pod install (retry)
end
deactivate Script
GH-->>GH: continue build steps
sequenceDiagram
autonumber
participant App as Android App
participant SoLoader as SoLoader
participant Mapping as OpenSourceMergedSoMapping
App->>SoLoader: SoLoader.init(this, OpenSourceMergedSoMapping)
SoLoader->>Mapping: load merged .so mapping
SoLoader-->>App: native libs initialized
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
transphorm
changed the title
transphorm
force-pushed
the
codex/update-core-tooling-for-react-native-upgrade
branch
from
d80aae4 to
fc3ee0d
Compare
Member
Author
|
@coderabbitai full summary |
Contributor
|
@transphorm I'll regenerate a comprehensive summary for this React Native upgrade preparation PR. Based on the PR objectives, this is preparatory work for upgrading to React Native 0.76.9, involving infrastructure updates including Node.js 22 and Xcode 15+ requirements, Android Gradle Plugin bump to 8.6, Gradle wrapper to 8.10.2, and raising Android minSdkVersion to 24. The testing results show expected build failures during this preparation phase, which is typical for infrastructure updates of this scope. 🧠 Learnings used✅ Actions performedSummary regeneration triggered. |
Contributor
|
@transphorm I'll regenerate a comprehensive full summary for this React Native upgrade preparation PR. This PR represents the foundational infrastructure preparation for upgrading to React Native 0.76.9, involving critical toolchain and dependency updates that need to be in place before the actual React Native version bump. The expected build failures during testing are typical for this preparation phase, as the infrastructure changes create temporary incompatibilities that will be resolved with the actual RN upgrade. 🧠 Learnings used✅ Actions performedSummary regeneration triggered. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 7
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
app/android/android-passport-reader/build.gradle (1)
16-21: Remove deprecated jcenter() and gate mavenLocal() for secure, reproducible buildsjcenter() is sunset and can break builds or pull stale artifacts. mavenLocal() can accidentally shadow remote artifacts, increasing supply-chain risk—particularly risky for a passport/security-related module. Keep google() + mavenCentral() by default; gate mavenLocal() behind an explicit Gradle property for local dev only.
Apply:
repositories { - google() - jcenter() - mavenCentral() - mavenLocal() + google() + mavenCentral() + if (findProperty("useMavenLocal")?.toString() == "true") { + mavenLocal() + } } ... allprojects { repositories { - - google() - jcenter() - mavenCentral() - mavenLocal() + google() + mavenCentral() + if (findProperty("useMavenLocal")?.toString() == "true") { + mavenLocal() + } } }Also applies to: 33-39
common/package.json (1)
284-288: Ensure@selfxyz/commondist artifacts are generated before module resolutionOur verification shows the
common/distdirectory is missing in this branch, so the export mapping for./utils/provingwill fail at consume-time:
- Option A (Recommended): Build
@selfxyz/commonbefore running workspace lint/types/test.
• Update your root-level CI or scripts, for example inpackage.json:"scripts": {- "ci": "yarn lint && yarn test",
- "ci": "yarn workspace @selfxyz/common build && yarn lint && yarn test",
…
}This guarantees `dist/esm/src/utils/proving.js` and `dist/cjs/src/utils/proving.cjs` exist before any import resolution. - **Option B:** Make `@selfxyz/common` self-sufficient by emitting `dist` on install. In `common/package.json`, add: ```diff "scripts": { "build": "tsup && yarn build:types && yarn postbuild", + "prepare": "yarn build", "postbuild": "node ./scripts/postBuild.mjs" },And ensure Yarn 4 lifecycle scripts run by enabling them in
.yarnrc.yml:enableScripts: truePlease apply one of these fixes so imports like
@selfxyz/common/utils/provingreliably resolve in development, CI, and downstream consumers.
🧹 Nitpick comments (2)
app/tests/src/androidBuildGradle.test.ts (1)
31-31: Add version guardrails for the Android build toolchainTo prevent accidental downgrades of your Android build environment, extend this test suite—beyond the existing
minSdkVersioncheck—to also assert:
- Android Gradle Plugin is pinned to
8.6.xin your rootbuild.gradle- Gradle wrapper distribution is pinned to
8.10.2in allgradle-wrapper.propertiesfilesExample additions to
app/tests/src/androidBuildGradle.test.ts:// existing SDK-level assertion expect(rootGradleContent).toMatch(/minSdkVersion\s*=\s*24/); + // guardrail: AGP version + expect(rootGradleContent).toMatch( + /com\.android\.tools\.build:gradle:8\.6\.\d+/ + ); + + // guardrail: Gradle wrapper version + const wrapperContent = fs.readFileSync( + path.join(projectRoot, 'android', 'gradle', 'wrapper', 'gradle-wrapper.properties'), + 'utf-8' + ); + expect(wrapperContent).toMatch( + /distributionUrl=.*gradle-8\.10\.2-bin\.zip/ + );This ensures that any future changes to your Android projects can’t inadvertently downgrade the plugin or wrapper versions.
app/android/android-passport-reader/app/build.gradle (1)
79-79: Remove unnecessary multidex dependency at minSdk 24With native multidex on API 21+ and this being a library,
androidx.multidex:multidexadds method count and build time without benefit.- implementation 'androidx.multidex:multidex:2.0.1'
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (3)
app/Gemfile.lockis excluded by!**/*.lockapp/ios/Podfile.lockis excluded by!**/*.lockyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (15)
README.md(1 hunks)app/AGENTS.md(1 hunks)app/README.md(2 hunks)app/android/android-passport-reader/app/build.gradle(1 hunks)app/android/android-passport-reader/build.gradle(1 hunks)app/android/android-passport-reader/gradle/wrapper/gradle-wrapper.properties(1 hunks)app/android/build.gradle(2 hunks)app/fastlane/DEV.md(3 hunks)app/fastlane/README.md(1 hunks)app/fastlane/test/helpers_test.rb(1 hunks)app/ios/Podfile(1 hunks)app/jest.setup.js(1 hunks)app/package.json(2 hunks)app/tests/src/androidBuildGradle.test.ts(1 hunks)common/package.json(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
app/android/**/*
⚙️ CodeRabbit configuration file
app/android/**/*: Review Android-specific code for:
- Platform-specific implementations
- Performance considerations
- Security best practices for mobile
Files:
app/android/android-passport-reader/gradle/wrapper/gradle-wrapper.propertiesapp/android/android-passport-reader/app/build.gradleapp/android/android-passport-reader/build.gradleapp/android/build.gradle
**/*.{test,spec}.{ts,js,tsx,jsx}
⚙️ CodeRabbit configuration file
**/*.{test,spec}.{ts,js,tsx,jsx}: Review test files for:
- Test coverage completeness
- Test case quality and edge cases
- Mock usage appropriateness
- Test readability and maintainability
Files:
app/tests/src/androidBuildGradle.test.ts
app/ios/**/*
⚙️ CodeRabbit configuration file
app/ios/**/*: Review iOS-specific code for:
- Platform-specific implementations
- Performance considerations
- Security best practices for mobile
Files:
app/ios/Podfile
🧠 Learnings (3)
📓 Common learnings
Learnt from: transphorm
PR: selfxyz/self#636
File: app/ios/Podfile:14-14
Timestamp: 2025-06-30T15:27:13.795Z
Learning: React Native 0.80 supports iOS 15.1 as the minimum deployment target, not iOS 16.0. This allows for broader device compatibility while still being compatible with the React Native 0.80 upgrade.
Learnt from: transphorm
PR: selfxyz/self#636
File: app/android/app/build.gradle:76-76
Timestamp: 2025-06-30T15:51:11.193Z
Learning: For React Native 0.80, the correct JSC version is `io.github.react-native-community:jsc-android:2026004.+`. This version was specifically built with Android NDK r23 to align with React Native 0.80's NDK requirements and prevent compatibility issues. The `2026004` version pattern is the official version for RN 0.80, not an outdated pin.
📚 Learning: 2025-06-30T15:51:11.193Z
Learnt from: transphorm
PR: selfxyz/self#636
File: app/android/app/build.gradle:76-76
Timestamp: 2025-06-30T15:51:11.193Z
Learning: For React Native 0.80, the correct JSC version is `io.github.react-native-community:jsc-android:2026004.+`. This version was specifically built with Android NDK r23 to align with React Native 0.80's NDK requirements and prevent compatibility issues. The `2026004` version pattern is the official version for RN 0.80, not an outdated pin.
Applied to files:
app/package.json
📚 Learning: 2025-07-14T09:03:08.292Z
Learnt from: aaronmgdr
PR: selfxyz/self#763
File: app/.github/workflows/test-coverage.yml:0-0
Timestamp: 2025-07-14T09:03:08.292Z
Learning: Node.js 22 is supported by actions/setup-nodev4 and has been in Active LTS since October 2024. It works on Linux, macOS, and Windows runners (Windows issues were resolved after version 22.8.0).
Applied to files:
app/fastlane/DEV.md
🪛 LanguageTool
app/AGENTS.md
[grammar] ~7-~7: There might be a mistake here.
Context: ...d Line Tools, CocoaPods (Ruby installed) - From app/ios: `bundle install && bundl...
(QB_NEW_EN)
app/README.md
[grammar] ~28-~28: There might be a mistake here.
Context: ...e](https://developer.apple.com/xcode/) | | cocoapods | Latest | [Install cocoa...
(QB_NEW_EN)
🪛 markdownlint-cli2 (0.17.2)
app/fastlane/DEV.md
144-144: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
153-153: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
627-627: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: run_circuit_tests
- GitHub Check: analyze-android
- GitHub Check: build
🔇 Additional comments (9)
app/tests/src/androidBuildGradle.test.ts (1)
31-31: Assertion bump to minSdkVersion 24 aligns with AGP 8.6 and Android policyThe updated expectation to 24 is correct given the project’s Gradle/AGP upgrades and minSdk raise across android modules.
README.md (1)
70-70: Docs: Node 22 and Xcode 15+ requirement is accurateClear prerequisite callout. This matches the toolchain updates elsewhere in the repo.
app/README.md (1)
7-7: Prereqs updated to Node >= 22 and Xcode >= 15Good alignment with the upgraded Android toolchain and iOS/Xcode baseline across the repo.
Also applies to: 28-28
app/AGENTS.md (1)
7-7: ✅ Xcode 15+ requirement verified in CI and docs
- CI workflows (
mobile-e2e.yml,mobile-deploy.yml,mobile-ci.yml) all setXCODE_VERSION: 16.4and invokesetup-xcode, ensuring Xcode ≥ 15 onmacos-latestrunners.- Bundle-analysis jobs (
mobile-bundle-analysis.yml) run onmacos-14, which uses the default Xcode ≥ 15 installation.- Podfile specifies
platform :ios, "15.1"(line 14), matching the documented minimum.No further changes required.
app/fastlane/test/helpers_test.rb (1)
224-224: LGTM: Test fixture aligns with minSdkVersion 24 across Android configsUpdating the inline Gradle snippet to minSdkVersion 24 keeps tests consistent with the project-wide SDK bump.
app/package.json (2)
117-117: Inconsistent RN version vs PR description and test setupYou’ve bumped
react-nativeto0.76.9, while the PR description claims RN remains at0.75.4. This inconsistency can cascade into Jest mocks, Gradle plugin expectations, and iOS Pods resolution.If 0.76.9 is intended for this PR:
- Update the PR description to reflect the bump.
- Confirm iOS Podfile and Android Gradle plugin configs are aligned (Hermes by default, SDK 35, Kotlin ≥ 1.9.24).
If it’s not intended, revert RN to 0.75.4 to stabilize CI for the tooling prep step.
195-197: Engines constraint matches docs—good to enforce Node 22The engines pin to Node 22 aligns with the updated prerequisites and helps avoid subtle toolchain issues on RN 0.76.x.
app/fastlane/DEV.md (1)
144-154: Toolchain prerequisites aligned (Node 22, Xcode 15+)Raising Node to 22 and documenting Xcode 15+ matches the Android/iOS build system updates in this PR and should reduce environment drift.
Also applies to: 627-629
app/android/build.gradle (1)
6-9: minSdk 24 alignment looks goodRaising
minSdkVersionto 24 is consistent with the rest of the Android changes and unlocks native multidex and newer APIs.
app/android/android-passport-reader/gradle/wrapper/gradle-wrapper.properties
Outdated
Show resolved
Hide resolved
…rade - Add fallback logic to run 'pod update hermes-engine' when pod install fails - This resolves CocoaPods cache issues that occur after React Native version upgrades - Fixes CI pipeline failures on codex/update-core-tooling-for-react-native-upgrade branch
- Preemptively clear CocoaPods cache before pod install - This prevents dependency analysis failures that occur when cached podspecs conflict - Addresses the root cause: cache conflicts during 'Analyzing dependencies' phase - Keeps fallback logic for additional safety
- Add pod-install-with-cache-fix.sh script to handle hermes-engine cache conflicts - Update install-app:setup script to use the new cache fix approach - This fixes the mobile-bundle-analysis.yml workflow failures after React Native upgrade - Proactively clears CocoaPods cache and has fallback for hermes-engine updates
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
.github/workflows/mobile-ci.yml (3)
187-189: Cache key bug: nested ${{ }} inside hashFiles prevents evaluationhashFiles receives the literal string "app/ios/${{ env.IOS_PROJECT_NAME }}.xcworkspace/..." so the second hash becomes empty, weakening cache keys and risking cross‑workspace pollution. Use a glob or compute the path once.
- key: ${{ runner.os }}-xcode-${{ hashFiles('app/ios/Podfile.lock') }}-${{ hashFiles('app/ios/${{ env.IOS_PROJECT_NAME }}.xcworkspace/contents.xcworkspacedata') }} + key: ${{ runner.os }}-xcode-${{ env.XCODE_VERSION }}-${{ hashFiles('app/ios/Podfile.lock') }}-${{ hashFiles('app/ios/*.xcworkspace/contents.xcworkspacedata') }}
174-180: Ineffective caching: restoring CocoaPods cache that you immediately deleteYou restore ~/Library/Caches/CocoaPods then delete it during Install iOS Dependencies. This wastes CI time and bandwidth. Either stop clearing it in CI or stop caching it. Given the new guarded install flow explicitly clears caches, remove it from the cached paths.
path: | app/ios/Pods - ~/Library/Caches/CocoaPods lock-file: app/ios/Podfile.lockIf you prefer to keep caching CocoaPods cache, gate the clear step with an env flag (e.g., CLEAR_POD_CACHE=false in CI).
207-223: Update CI to use NDK r26.1 (not r27) with RN 0.76 + AGP 8.6
AGP 8.6 defaults to Android NDK 26.1.10909125 (if you don’t explicitly setndkVersion, AGP will install and use that release) (developer.android.com). Building with NDK r27 may trigger version-mismatch warnings (and hasn’t been validated against RN 0.76’s toolchain), risking subtle ABI/toolchain issues.Please adjust as follows:
- In
.github/workflows/mobile-ci.yml, set
ANDROID_NDK_VERSION: "26.1.10909125"(instead of any r27 value).- Optionally, pin the same value in your module’s
android { ndkVersion "26.1.10909125" }block to align local builds with CI.
♻️ Duplicate comments (1)
app/package.json (1)
150-155: Align @react-native/gradle-plugin with RN minor to avoid build-logic mismatchesUsing ^0.81.0 alongside react-native 0.76.9 can introduce incompatible Gradle tasks and flags. Pin the plugin to the matching RN minor.
- "@react-native/gradle-plugin": "^0.81.0", + "@react-native/gradle-plugin": "0.76.9",
🧹 Nitpick comments (1)
app/ios/scripts/pod-install-with-cache-fix.sh (1)
6-11: Harden the script: enable pipefail/undef checks to avoid masking failuresAdd -u and -o pipefail so any unset var or piped command failure aborts early. This prevents partial installs that later cause flaky builds.
-set -e # Exit on any error +set -euo pipefail # Exit on error, undefined var, or failed pipe
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
.github/workflows/mobile-ci.yml(1 hunks)app/ios/scripts/pod-install-with-cache-fix.sh(1 hunks)app/package.json(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
app/ios/**/*
⚙️ CodeRabbit configuration file
app/ios/**/*: Review iOS-specific code for:
- Platform-specific implementations
- Performance considerations
- Security best practices for mobile
Files:
app/ios/scripts/pod-install-with-cache-fix.sh
🧠 Learnings (4)
📓 Common learnings
Learnt from: transphorm
PR: selfxyz/self#636
File: app/ios/Podfile:14-14
Timestamp: 2025-06-30T15:27:13.795Z
Learning: React Native 0.80 supports iOS 15.1 as the minimum deployment target, not iOS 16.0. This allows for broader device compatibility while still being compatible with the React Native 0.80 upgrade.
📚 Learning: 2025-08-02T23:53:45.928Z
Learnt from: transphorm
PR: selfxyz/self#823
File: app/ios/Self.xcodeproj/project.pbxproj:320-332
Timestamp: 2025-08-02T23:53:45.928Z
Learning: When reviewing autogenerated scripts in Xcode project files (like React Native Firebase's embedded shell scripts), avoid suggesting edits since these are regenerated during pod install and cannot be manually modified by users.
Applied to files:
app/ios/scripts/pod-install-with-cache-fix.shapp/package.json
📚 Learning: 2025-07-29T01:08:28.530Z
Learnt from: transphorm
PR: selfxyz/self#795
File: app/android/app/build.gradle:157-158
Timestamp: 2025-07-29T01:08:28.530Z
Learning: For this React Native project, the team prefers build flexibility over fail-fast behavior for release builds in app/android/app/build.gradle. They intentionally allow fallback to debug signing for local development runs, relying on Google Play Console validation to catch any improperly signed releases during upload.
Applied to files:
app/package.json
📚 Learning: 2025-06-30T15:51:11.193Z
Learnt from: transphorm
PR: selfxyz/self#636
File: app/android/app/build.gradle:76-76
Timestamp: 2025-06-30T15:51:11.193Z
Learning: For React Native 0.80, the correct JSC version is `io.github.react-native-community:jsc-android:2026004.+`. This version was specifically built with Android NDK r23 to align with React Native 0.80's NDK requirements and prevent compatibility issues. The `2026004` version pattern is the official version for RN 0.80, not an outdated pin.
Applied to files:
app/package.json
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: analyze-android
- GitHub Check: analyze-ios
- GitHub Check: run_circuit_tests
- GitHub Check: build
🔇 Additional comments (1)
app/package.json (1)
117-118: Scope drift: RN is now 0.76.9—confirm intent vs. “prep only” PR descriptionThe dependency bump upgrades RN to 0.76.9. If this PR is meant to be infra‑only, either revert this change or update the PR title/description and ensure Android/iOS settings are fully aligned (AGP 8.6, Gradle 8.10.2, iOS Hermes pods, CLI/tooling versions).
Would you like me to generate a follow‑up checklist (Android/iOS) for a clean RN 0.76 rollout?
- Apply comprehensive cache clearing to mobile-ci.yml and mobile-e2e.yml - Pre-emptively run 'pod update hermes-engine' before pod install - Clear multiple cache locations to handle CI environment differences - This prevents 'hermes-engine differs from Pods/Local Podspecs' errors - Fixes all workflows affected by React Native 0.76.9 upgrade cache issues
transphorm
had a problem deploying
to
development
GitHub Actions
Failure
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (6)
.github/workflows/circuits.yml(1 hunks).github/workflows/common-ci.yml(4 hunks)app/package.json(4 hunks)common/package.json(1 hunks)packages/mobile-sdk-alpha/package.json(2 hunks)scripts/tests/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- common/package.json
- scripts/tests/package.json
🚧 Files skipped from review as they are similar to previous changes (2)
- packages/mobile-sdk-alpha/package.json
- app/package.json
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: build-ios
- GitHub Check: test
- GitHub Check: build-android
- GitHub Check: analyze-android
- GitHub Check: e2e-ios
- GitHub Check: run_circuit_tests
Comment on lines
+118
to
+126
| - name: Cache Yarn dependencies | ||
| uses: ./.github/actions/cache-yarn | ||
| with: | ||
| path: | | ||
| .yarn/cache | ||
| node_modules | ||
| circuits/node_modules | ||
| cache-version: v1 | ||
|
|
Contributor
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Avoid caching node_modules; key the cache to lockfile/Node/Yarn to prevent stale deps and ABI mismatches
Caching node_modules is risky with Node 22 and native addons (e.g., sharp, keccak): binary artifacts become invalid across Node or lib changes and can cause nondeterministic CI flakes. Prefer caching only Yarn’s artifact cache (.yarn/cache) and let yarn install (with Corepack) rebuild node_modules deterministically. If you must cache node_modules, ensure the cache key includes at minimum: runner.os, Node version, Yarn version, and a hash of all relevant lockfiles. Also align the cache “version” with RN 0.76 to force a bust during this upgrade.
Apply this conservative diff to remove node_modules caching and bump the cache bucket:
- name: Cache Yarn dependencies
uses: ./.github/actions/cache-yarn
with:
path: |
.yarn/cache
- node_modules
- circuits/node_modules
- cache-version: v1
+ cache-version: rn-0.76-node22-v1Additionally, please explicitly set Node 22 in this workflow (missing today). Add a setup step after checkout so installs/builds run on the intended runtime:
# Insert after "uses: actions/checkout@v4"
- name: Setup Node.js 22 and enable Corepack
uses: actions/setup-node@v4
with:
node-version: '22'
cache: 'yarn'
cache-dependency-path: |
**/yarn.lock
- run: corepack enableTo confirm your local cache action is safe to keep even when not caching node_modules, please verify its cache key includes lockfile/Node/Yarn/OS entropy:
🏁 Script executed:
#!/bin/bash
# Inspect the local cache-yarn action composition and keying
fd -a cache-yarn .github/actions
rg -n "key:|restore-keys:|hashFiles|cache-version" -n .github/actions/cache-yarn -S -C2
cat .github/actions/cache-yarn/action.yml || cat .github/actions/cache-yarn/action.yamlLength of output: 1961
🏁 Script executed:
#!/bin/bash
# Check for Node.js setup in circuits CI workflow
rg -n "actions/setup-node@" -n .github/workflows/circuits.yml || echo "No setup-node step found"
rg -n "node-version" -n .github/workflows/circuits.yml || echo "No node-version specified"
rg -n "corepack" -n .github/workflows/circuits.yml || echo "No corepack usage found"Length of output: 344
Enforce deterministic installs: drop node_modules from cache and pin Node.js 22
The current workflow is caching both .yarn/cache and the entire node_modules folders, but without including Node or Yarn versions in the cache key. This risks CI flakes and ABI mismatches for native modules (e.g. sharp, keccak) when moving between Node or library versions. Additionally, we’re not explicitly selecting a Node runtime, so installs may run on an unintended version.
Areas to address:
- .github/workflows/circuits.yml (lines 118–126): invocation of the cache-yarn action
- .github/workflows/circuits.yml: insert a Node.js setup step after
actions/checkout@v4
Diff to apply:
- name: Cache Yarn dependencies
uses: ./.github/actions/cache-yarn
with:
path: |
.yarn/cache
- node_modules
- circuits/node_modules
- cache-version: v1
+ cache-version: rn-0.76-node22-v1And add this snippet immediately after checkout to pin Node 22 and enable Corepack:
# Insert after "uses: actions/checkout@v4"
- name: Setup Node.js 22 and enable Corepack
uses: actions/setup-node@v4
with:
node-version: '22'
cache: 'yarn'
cache-dependency-path: |
**/yarn.lock
- run: corepack enable🤖 Prompt for AI Agents
.github/workflows/circuits.yml lines 118-126: the workflow is caching
node_modules and not pinning Node/Yarn which can cause non-deterministic
installs and native ABI mismatches; remove node_modules from the cache paths so
only .yarn/cache (and any per-package caches) are stored, and update the cache
action invocation to include a versioned cache key that incorporates Node and
Yarn versions; also insert a step immediately after actions/checkout@v4 to setup
Node.js 22 and enable Corepack (use actions/setup-node@v4 with node-version:
'22' and cache: 'yarn' and run corepack enable) so CI always uses Node 22 and
deterministic Yarn installs.
Comment on lines
+12
to
+19
| - name: Cache Yarn dependencies | ||
| uses: ./.github/actions/cache-yarn | ||
| with: | ||
| path: | | ||
| .yarn/cache | ||
| node_modules | ||
| common/node_modules | ||
| cache-version: v1 |
Contributor
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
CI uses Node 22 in docs, but workflows don’t pin it; also avoid caching node_modules across jobs
Given the RN 0.76/Node 22 migration, each job should explicitly set Node 22. Without pinning, ubuntu-latest may use Node 20, causing native module rebuilds, eslint/type-check variance, and flaky failures. Separately, caching node_modules in four jobs multiplies cache size and increases stale/ABI risk. Cache only .yarn/cache (or ensure keys incorporate OS, Node, Yarn, and lockfile hashes).
For each of the four “Cache Yarn dependencies” steps, remove node_modules from the cache and bump the cache bucket:
- name: Cache Yarn dependencies
uses: ./.github/actions/cache-yarn
with:
path: |
.yarn/cache
- node_modules
- common/node_modules
- cache-version: v1
+ cache-version: rn-0.76-node22-v1Add Node setup at the top of each job (build, lint, type-check, test-common), right after checkout:
- name: Setup Node.js 22 and enable Corepack
uses: actions/setup-node@v4
with:
node-version: '22'
cache: 'yarn'
cache-dependency-path: |
**/yarn.lock
- run: corepack enableIf keeping node_modules in the cache is deemed necessary, first confirm the local action’s keying includes lockfile and runtime entropy:
Also applies to: 36-43, 56-63, 86-93
🏁 Script executed:
#!/bin/bash
# Check cache key/restore-keys strategy for the local action
fd -a cache-yarn .github/actions
rg -n "actions/cache|key:|restore-keys:|hashFiles|cache-version" -n .github/actions/cache-yarn -S -C2Length of output: 1234
Pin Node.js 22 & tighten the Yarn cache key
The CI docs target Node 22, but none of the workflows set up or pin Node. On ubuntu-latest, this can slip back to Node 20, leading to native‐module ABI mismatches, inconsistent ESLint/type‐check results, and flaky failures. Furthermore, caching node_modules (and common/node_modules) across four jobs significantly bloats your cache and invites staleness whenever the runtime changes.
Your local cache action currently builds its key from:
runner.osinputs.cache-versionhashFiles(inputs.lock-file)
…but it doesn’t include the Node or Yarn version. To ensure robust cache busting when you migrate runtimes, you should either bump cache-version to encode your Node upgrade (e.g. rn-0.76-node22-v1) or extend the action to accept a node-version input and include it in its key.
Action items
– In .github/workflows/common-ci.yml (jobs: build, lint, type-check, test-common), right after checkout add:
- name: Setup Node.js 22 and enable Corepack
uses: actions/setup-node@v4
with:
node-version: '22'
cache: 'yarn'
cache-dependency-path: |
**/yarn.lock
- run: corepack enable– For each “Cache Yarn dependencies” step (≈ lines 12–19, 36–43, 56–63, 86–93):
• Remove node_modules and common/node_modules from with.path
• Bump cache-version to include your Node bump (or add a node-version input)
• Example diff:
- name: Cache Yarn dependencies
uses: ./.github/actions/cache-yarn
with:
path: |
.yarn/cache
- node_modules
- common/node_modules
- cache-version: v1
+ cache-version: rn-0.76-node22-v1This will:
- Guarantee Node 22 everywhere (avoiding ABI and lint/type‐check drift)
- Keep your caches small and auto‐invalidate on lockfile or runtime bumps
🤖 Prompt for AI Agents
.github/workflows/common-ci.yml lines 12-19: the workflow neither pins Node nor
includes Node/Yarn in the cache key and currently caches node_modules which
bloats/stales the cache; update each job (build, lint, type-check, test-common)
to set up Node.js 22 and enable Corepack immediately after checkout (use
actions/setup-node@v4 with node-version: '22' and cache: 'yarn', then run
corepack enable), and for every "Cache Yarn dependencies" step (around lines
12–19, 36–43, 56–63, 86–93) remove node_modules and common/node_modules from
with.path and bump the cache-version to encode the Node upgrade (or extend the
local cache action to accept a node-version input and include it in its key) so
caches are smaller and correctly invalidated on runtime or lockfile changes.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (4)
.github/workflows/common-ci.yml (4)
12-19: Stop caching node_modules; pin Node 22 for deterministic buildsCaching node_modules across jobs and runners is brittle with RN 0.76/Node 22; it increases flakiness and ABI drift. Also, the workflow doesn’t pin Node, so jobs may run on Node 20. Fix both.
Apply this diff to the Yarn cache step:
- name: Cache Yarn dependencies uses: ./.github/actions/cache-yarn with: path: | .yarn/cache - node_modules - common/node_modules - cache-version: v1 + cache-version: rn-0.76-node22-v1Then add Node setup right after checkout (outside the selected range):
- name: Setup Node.js 22 and enable Corepack uses: actions/setup-node@v4 with: node-version: '22' - run: corepack enable
36-43: Same here: avoid node_modules cache and bump the cache key; set Node 22Repeats the pattern from build. Remove node_modules paths, bump cache-version to encode the runtime upgrade, and set up Node 22 at the top of the job.
- name: Cache Yarn dependencies uses: ./.github/actions/cache-yarn with: path: | .yarn/cache - node_modules - common/node_modules - cache-version: v1 + cache-version: rn-0.76-node22-v1Add (outside the range) after checkout:
- name: Setup Node.js 22 and enable Corepack uses: actions/setup-node@v4 with: node-version: '22' - run: corepack enable
56-63: Type-check job needs the same Node pin and slimmer cacheThis job will otherwise inherit whatever Node ubuntu-latest ships and will restore potentially stale node_modules. Align with the other jobs.
- name: Cache Yarn dependencies uses: ./.github/actions/cache-yarn with: path: | .yarn/cache - node_modules - common/node_modules - cache-version: v1 + cache-version: rn-0.76-node22-v1Add (outside the range) after checkout:
- name: Setup Node.js 22 and enable Corepack uses: actions/setup-node@v4 with: node-version: '22' - run: corepack enable
88-95: Repeat: slim Yarn cache and pin Node 22 for testsTests will be sensitive to ABI and PnP/runtime drift. Remove node_modules from cache and pin Node 22.
- name: Cache Yarn dependencies uses: ./.github/actions/cache-yarn with: path: | .yarn/cache - node_modules - common/node_modules - cache-version: v1 + cache-version: rn-0.76-node22-v1Add (outside the range) after checkout:
- name: Setup Node.js 22 and enable Corepack uses: actions/setup-node@v4 with: node-version: '22' - run: corepack enable
🧹 Nitpick comments (1)
.github/workflows/mobile-e2e.yml (1)
362-375: Make workspace resolution scheme-aware to avoid later failures and wasted cyclesCurrently, you pick OpenPassport.xcworkspace if it exists and lists “OpenPassport”, otherwise you default to Self.xcworkspace, and only in the Build step do you fail if the scheme isn’t present. Tighten selection to choose the workspace that actually contains the configured scheme ($IOS_PROJECT_SCHEME), failing early with diagnostics if neither does.
Apply:
- - name: Resolve iOS workspace - run: | - WORKSPACE_OPEN="app/ios/OpenPassport.xcworkspace" - WORKSPACE_SELF="app/ios/Self.xcworkspace" - - if xcodebuild -list -workspace "$WORKSPACE_OPEN" 2>/dev/null | grep -q "OpenPassport"; then - WORKSPACE_PATH="$WORKSPACE_OPEN" - else - WORKSPACE_PATH="$WORKSPACE_SELF" - fi - - echo "WORKSPACE_PATH=$WORKSPACE_PATH" >> "$GITHUB_ENV" - echo "Resolved workspace: $WORKSPACE_PATH" + - name: Resolve iOS workspace + run: | + set -euo pipefail + SCHEME="${IOS_PROJECT_SCHEME:-OpenPassport}" + CANDIDATES=("app/ios/OpenPassport.xcworkspace" "app/ios/Self.xcworkspace") + + has_scheme() { + local ws="$1" + xcodebuild -list -workspace "$ws" 2>/dev/null \ + | awk '/Schemes:/{flag=1;next}/^$/{flag=0}flag' \ + | grep -Fxq "$SCHEME" + } + + WORKSPACE_PATH="" + for ws in "${CANDIDATES[@]}"; do + if [ -d "$ws" ] && has_scheme "$ws"; then + WORKSPACE_PATH="$ws" + break + fi + done + + if [ -z "${WORKSPACE_PATH}" ]; then + echo "❌ Could not find scheme '$SCHEME' in any candidate workspace." + echo "Available schemes per workspace:" + for ws in "${CANDIDATES[@]}"; do + if [ -d "$ws" ]; then + echo "— $ws" + xcodebuild -list -workspace "$ws" 2>/dev/null | awk '/Schemes:/{flag=1;next}/^$/{flag=0}flag' || true + fi + done + exit 1 + fi + + echo "WORKSPACE_PATH=$WORKSPACE_PATH" >> "$GITHUB_ENV" + echo "Resolved workspace: $WORKSPACE_PATH (scheme: $SCHEME)"
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
.github/workflows/common-ci.yml(5 hunks).github/workflows/mobile-ci.yml(14 hunks).github/workflows/mobile-e2e.yml(4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/mobile-ci.yml
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-08-02T23:53:45.928Z
Learnt from: transphorm
PR: selfxyz/self#823
File: app/ios/Self.xcodeproj/project.pbxproj:320-332
Timestamp: 2025-08-02T23:53:45.928Z
Learning: When reviewing autogenerated scripts in Xcode project files (like React Native Firebase's embedded shell scripts), avoid suggesting edits since these are regenerated during pod install and cannot be manually modified by users.
Applied to files:
.github/workflows/mobile-e2e.yml
📚 Learning: 2025-08-24T18:52:25.766Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.766Z
Learning: Use yarn scripts: yarn ios/android for builds, yarn test for unit tests, and Fastlane for deployments
Applied to files:
.github/workflows/common-ci.yml
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: build-android
- GitHub Check: build-ios
- GitHub Check: analyze-android
- GitHub Check: e2e-ios
- GitHub Check: run_circuit_tests
🔇 Additional comments (4)
.github/workflows/mobile-e2e.yml (4)
256-259: Good hardening: version-scope all Xcode-related caches by env.XCODE_VERSIONIncluding env.XCODE_VERSION in the keys/restore-keys for DerivedData, Index, and Simulator prevents stale ABI/cache reuse after runner/Xcode image bumps. This will reduce nondeterministic link/compile errors and simulator runtime mismatches.
Also applies to: 264-266, 273-275
289-291: Pods install via centralized Bundler script is the right moveDelegating to scripts/pod-install-with-cache-fix.sh under bundle exec eliminates drift and consolidates Hermes/CocoaPods cache remediation. This should materially cut iOS CI flakiness after the RN 0.76.x upgrade.
381-384: Early guard for empty WORKSPACE_PATH is goodFailing fast here avoids ambiguous xcodebuild errors and improves triage speed. This pairs well with the Resolve step above when made scheme-aware.
236-241: Fix Bundler cache scope by movingworking-directoryto the step levelVerified via script that your Gemfile lives at
app/Gemfile, so theworking-directoryinput underwithis ignored byruby/setup-rubyand defaults to the repo root, causing your gems to be cached/installed in the wrong location.• File: .github/workflows/mobile-e2e.yml
• Step: “Set up Ruby” (around lines 236–241)Apply this diff to move
working-directoryout ofwithand onto the step:- - name: Set up Ruby - uses: ruby/setup-ruby@v1 - with: - ruby-version: "3.3" - bundler-cache: true - working-directory: app + - name: Set up Ruby + uses: ruby/setup-ruby@v1 + with: + ruby-version: "3.3" + bundler-cache: true + working-directory: appLikely an incorrect or invalid review comment.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (4)
.github/workflows/common-ci.yml (4)
12-19: Don’t cache node_modules; pin Node.js 22 for RN 0.76 to avoid ABI drift and flakiness.Caching node_modules across jobs + not pinning Node will cause inconsistent native builds and lint/type-check variance after the RN 0.76/Node 22 bump. Keep only .yarn/cache and bump the cache bucket; set up Node 22 + Corepack in each job immediately after checkout.
Apply within this range:
- name: Cache Yarn dependencies uses: ./.github/actions/cache-yarn with: path: | .yarn/cache - node_modules - common/node_modules - cache-version: v1 + cache-version: rn-0.76-node22-v1Add right after “uses: actions/checkout@v4” (outside this range) in every job:
- name: Setup Node.js 22 and enable Corepack uses: actions/setup-node@v4 with: node-version: '22' cache: 'yarn' cache-dependency-path: | **/yarn.lock - run: corepack enable
38-45: Repeat: remove node_modules from cache and pin Node 22.Same rationale as Lines 12–19: avoid ABI and tooling drift; keep caches small and valid across the RN upgrade.
Within this range:
- name: Cache Yarn dependencies uses: ./.github/actions/cache-yarn with: path: | .yarn/cache - node_modules - common/node_modules - cache-version: v1 + cache-version: rn-0.76-node22-v1Add Node setup step after checkout as shown in the earlier comment.
58-65: Repeat: remove node_modules from cache and pin Node 22 (type-check job).Type-checks are especially sensitive to Node/Yarn drift and native ABI. Same changes recommended here.
Within this range:
- name: Cache Yarn dependencies uses: ./.github/actions/cache-yarn with: path: | .yarn/cache - node_modules - common/node_modules - cache-version: v1 + cache-version: rn-0.76-node22-v1Add Node setup step after checkout as shown earlier.
90-97: Repeat: remove node_modules from cache and pin Node 22 (test-common job).Same fix as earlier hunks to prevent flaky native rebuilds in tests and reduce cache bloat.
Within this range:
- name: Cache Yarn dependencies uses: ./.github/actions/cache-yarn with: path: | .yarn/cache - node_modules - common/node_modules - cache-version: v1 + cache-version: rn-0.76-node22-v1Add Node setup step after checkout as shown earlier.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/common-ci.yml(3 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-08-24T18:52:25.766Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.766Z
Learning: Use yarn scripts: yarn ios/android for builds, yarn test for unit tests, and Fastlane for deployments
Applied to files:
.github/workflows/common-ci.yml
📚 Learning: 2025-08-24T18:54:04.799Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-08-24T18:54:04.799Z
Learning: Applies to packages/mobile-sdk-alpha/package.json : Expose a 'test:build' script in the SDK's package.json that runs build, test, types, and lint
Applied to files:
.github/workflows/common-ci.yml
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: e2e-ios
- GitHub Check: run_circuit_tests
🔇 Additional comments (1)
.github/workflows/common-ci.yml (1)
27-30: Potential path mismatch: common/dist vs packages/common/dist.You cache “common/dist” while other packages live under “packages/**”. If @selfxyz/common actually resides at packages/common, this cache never stores the intended artifacts. Please verify and adjust paths consistently in save/restore steps across jobs.
If your repo uses packages/common, apply:
path: | - common/dist + packages/common/dist packages/mobile-sdk-alpha/dist - key: build-deps-${{ runner.os }}-${{ hashFiles('common/**/*', 'packages/mobile-sdk-alpha/**/*', '!common/dist/**', '!packages/mobile-sdk-alpha/dist/**') }} + key: build-deps-${{ runner.os }}-${{ hashFiles('packages/common/**/*', 'packages/mobile-sdk-alpha/**/*', '!packages/common/dist/**', '!packages/mobile-sdk-alpha/dist/**') }}
Comment on lines
+22
to
+23
| - name: Build dependencies | ||
| run: yarn workspace @selfxyz/mobile-app run build:deps |
Contributor
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Guard against partial/empty builds before saving cache.
If build:deps succeeds only partially (or produces no dist), the subsequent cache.save may store empty dirs, and downstream jobs will “cache-hit” and skip rebuilding. Add a verification step that asserts dist contents exist, and gate the save step on the build step’s outcome plus the verification.
Proposed additions outside this range:
- name: Verify build outputs
id: verify-build
run: |
set -euo pipefail
test -d common/dist && [ -n "$(ls -A common/dist)" ] || { echo "common/dist missing or empty"; exit 1; }
test -d packages/mobile-sdk-alpha/dist && [ -n "$(ls -A packages/mobile-sdk-alpha/dist)" ] || { echo "packages/mobile-sdk-alpha/dist missing or empty"; exit 1; }
# Then gate the cache save step:
- name: Cache build artifacts
if: ${{ steps.verify-build.outcome == 'success' }}
uses: actions/cache/save@v4
with:
path: |
common/dist
packages/mobile-sdk-alpha/dist
key: build-deps-${{ runner.os }}-${{ hashFiles('common/**/*', 'packages/mobile-sdk-alpha/**/*', '!common/dist/**', '!packages/mobile-sdk-alpha/dist/**') }}To double-check the correct dist paths for @selfxyz/common in your repo structure, run:
🏁 Script executed:
#!/bin/bash
# Find the workspace location of @selfxyz/common to confirm whether it's 'common' or 'packages/common'
jq -r '.name + " " + .location' <<<"$(yarn workspaces list --json | jq -s add)" | grep '@selfxyz/common'Length of output: 570
I’ll locate the actual workspace folders for both @selfxyz/common and @selfxyz/mobile-sdk-alpha by scanning all package.json files:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "🔍 Finding @selfxyz/common package.json location"
rg -n '"name":\s*"@selfxyz/common"' -g '**/package.json'
echo "🔍 Finding @selfxyz/mobile-sdk-alpha package.json location"
rg -n '"name":\s*"@selfxyz/mobile-sdk-alpha"' -g '**/package.json'Length of output: 512
To verify exactly what build:deps produces (and which dist folders we need to guard), let’s extract the script definition from your @selfxyz/mobile-app workspace.
Once we know exactly which directories build:deps populates, we can lock in the verify+gate snippet for the cache step.
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# 1. Locate the mobile-app package.json
file=$(rg -l '"name":\s*"@selfxyz/mobile-app"' -g '**/package.json')
echo "📂 Found mobile-app package.json at: $file"
# 2. Print out the build:deps script so we can see its commands and output paths
echo "🔧 build:deps script:"
jq -r '.scripts["build:deps"]' "$file"Length of output: 414
To confirm the exact output directories used by each build script, let’s inspect both build definitions:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "🔧 common build script:"
jq -r '.scripts["build"]' common/package.json
echo "🔧 mobile-sdk-alpha build script:"
jq -r '.scripts["build"]' packages/mobile-sdk-alpha/package.jsonLength of output: 349
Ensure non-empty build artifacts before caching
To prevent an empty or partial build from being cached (causing downstream jobs to skip rebuilding), gate the cache save on a check that both common/dist and packages/mobile-sdk-alpha/dist exist and are non-empty.
• File: .github/workflows/common-ci.yml
– After the Build dependencies step, insert a verification step.
– Modify the existing cache step to run only if verification succeeds.
@@ .github/workflows/common-ci.yml
- name: Build dependencies
run: yarn workspace @selfxyz/mobile-app run build:deps
+ - name: Verify build outputs
+ id: verify-build
+ run: |
+ set -euo pipefail
+ test -d common/dist && [ "$(ls -A common/dist)" ] \
+ || { echo "ERROR: common/dist is missing or empty"; exit 1; }
+ test -d packages/mobile-sdk-alpha/dist && [ "$(ls -A packages/mobile-sdk-alpha/dist)" ] \
+ || { echo "ERROR: packages/mobile-sdk-alpha/dist is missing or empty"; exit 1; }
+
- - uses: actions/cache/save@v4
+ - if: steps.verify-build.outcome == 'success'
+ uses: actions/cache/save@v4
with:
path: |
common/dist
packages/mobile-sdk-alpha/dist
key: build-deps-${{ runner.os }}-${{ hashFiles(
'common/**/*',
'packages/mobile-sdk-alpha/**/*',
'!common/dist/**',
'!packages/mobile-sdk-alpha/dist/**'
) }}This guarantees caches are only populated when both dist folders have valid content.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - name: Build dependencies | |
| run: yarn workspace @selfxyz/mobile-app run build:deps | |
| - name: Build dependencies | |
| run: yarn workspace @selfxyz/mobile-app run build:deps | |
| - name: Verify build outputs | |
| id: verify-build | |
| run: | | |
| set -euo pipefail | |
| test -d common/dist && [ "$(ls -A common/dist)" ] \ | |
| || { echo "ERROR: common/dist is missing or empty"; exit 1; } | |
| test -d packages/mobile-sdk-alpha/dist && [ "$(ls -A packages/mobile-sdk-alpha/dist)" ] \ | |
| || { echo "ERROR: packages/mobile-sdk-alpha/dist is missing or empty"; exit 1; } | |
| - if: steps.verify-build.outcome == 'success' | |
| uses: actions/cache/save@v4 | |
| with: | |
| path: | | |
| common/dist | |
| packages/mobile-sdk-alpha/dist | |
| key: build-deps-${{ runner.os }}-${{ hashFiles( | |
| 'common/**/*', | |
| 'packages/mobile-sdk-alpha/**/*', | |
| '!common/dist/**', | |
| '!packages/mobile-sdk-alpha/dist/**' | |
| ) }} |
🤖 Prompt for AI Agents
In .github/workflows/common-ci.yml around lines 22-23, the workflow currently
caches build artifacts unconditionally after the "Build dependencies" step; add
a new step immediately after that which verifies both common/dist and
packages/mobile-sdk-alpha/dist exist and are non-empty (e.g., run a shell check
that sets an output or creates a file/exit status indicating success), and
update the subsequent cache save step to run only when that verification step
indicates success (use the verification step output or an if: condition so the
cache is saved only when both dist directories are present and non-empty).
Comment on lines
69
to
80
| id: restore-build-deps | ||
| uses: actions/cache/restore@v4 | ||
| with: | ||
| path: common/dist | ||
| key: common-build-${{ runner.os }}-${{ github.sha }} | ||
| path: | | ||
| common/dist | ||
| packages/mobile-sdk-alpha/dist | ||
| key: build-deps-${{ runner.os }}-${{ hashFiles('common/**/*', 'packages/mobile-sdk-alpha/**/*', '!common/dist/**', '!packages/mobile-sdk-alpha/dist/**') }} | ||
| fail-on-cache-miss: false | ||
| - name: Build @selfxyz/common (fallback on cache miss) | ||
| if: steps.restore-common-dist.outputs.cache-hit != 'true' | ||
| run: yarn workspace @selfxyz/common build | ||
| - name: Build dependencies (fallback on cache miss) | ||
| if: steps.restore-build-deps.outputs.cache-hit != 'true' | ||
| run: yarn workspace @selfxyz/mobile-app run build:deps | ||
| - name: Yarn types |
Contributor
There was a problem hiding this comment.
🛠️ Refactor suggestion
Treat “cache-hit but empty artifacts” as a miss; otherwise downstream types may break.
If restore hits but artifacts are empty/missing (e.g., saved from a bad run), you skip build:deps and then run yarn types with missing dists. Add a check step and extend the if condition to rebuild on missing artifacts.
Apply inside this range (adjusting the condition):
- - name: Build dependencies (fallback on cache miss)
- if: steps.restore-build-deps.outputs.cache-hit != 'true'
- run: yarn workspace @selfxyz/mobile-app run build:deps
+ - name: Build dependencies (fallback or if artifacts missing)
+ if: steps.restore-build-deps.outputs.cache-hit != 'true' || steps.check-artifacts.outputs.missing == 'true'
+ run: yarn workspace @selfxyz/mobile-app run build:depsAdd the “check-artifacts” step right after the Restore step (outside this range):
- name: Check build artifacts presence
id: check-artifacts
run: |
set -euo pipefail
missing=false
[ -d common/dist ] && [ -n "$(ls -A common/dist)" ] || missing=true
[ -d packages/mobile-sdk-alpha/dist ] && [ -n "$(ls -A packages/mobile-sdk-alpha/dist)" ] || missing=true
echo "missing=${missing}" >> "$GITHUB_OUTPUT"Optional but safer: replace cross-run caches with same-run artifacts (upload in build, download here) to eliminate global cache staleness.
Comment on lines
101
to
112
| id: restore-build-deps | ||
| uses: actions/cache/restore@v4 | ||
| with: | ||
| path: common/dist | ||
| key: common-build-${{ runner.os }}-${{ github.sha }} | ||
| path: | | ||
| common/dist | ||
| packages/mobile-sdk-alpha/dist | ||
| key: build-deps-${{ runner.os }}-${{ hashFiles('common/**/*', 'packages/mobile-sdk-alpha/**/*', '!common/dist/**', '!packages/mobile-sdk-alpha/dist/**') }} | ||
| fail-on-cache-miss: false | ||
| - name: Build @selfxyz/common (fallback on cache miss) | ||
| if: steps.restore-common-dist.outputs.cache-hit != 'true' | ||
| run: yarn workspace @selfxyz/common build | ||
| - name: Build dependencies (fallback on cache miss) | ||
| if: steps.restore-build-deps.outputs.cache-hit != 'true' | ||
| run: yarn workspace @selfxyz/mobile-app run build:deps | ||
| - name: Run @selfxyz/common tests |
Contributor
There was a problem hiding this comment.
🛠️ Refactor suggestion
Same artifact integrity concern as type-check; rebuild when restored artifacts are missing.
Mirror the “check + conditional rebuild” pattern here to avoid running tests with empty dists.
Apply inside this range:
- - name: Build dependencies (fallback on cache miss)
- if: steps.restore-build-deps.outputs.cache-hit != 'true'
- run: yarn workspace @selfxyz/mobile-app run build:deps
+ - name: Build dependencies (fallback or if artifacts missing)
+ if: steps.restore-build-deps.outputs.cache-hit != 'true' || steps.check-artifacts.outputs.missing == 'true'
+ run: yarn workspace @selfxyz/mobile-app run build:depsAdd the “check-artifacts” step after the Restore step (outside this range), identical to the one suggested for the type-check job.
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
.github/workflows/common-ci.yml lines 101-112: add a "check-artifacts" step
immediately after the restore-build-deps step (outside the shown range) that
mirrors the check from the type-check job: verify that common/dist and
packages/mobile-sdk-alpha/dist contain files (exit non-zero or set an output
flag when empty), then change the existing "Build dependencies (fallback on
cache miss)" step to run when the check indicates artifacts are missing (i.e.,
check output != 'true' or failure), ensuring tests never run against empty dists
and only rebuild when restored artifacts are absent or empty.
transphorm
commented
Aug 26, 2025
| ${{ runner.os }}-node-${{ env.NODE_VERSION_SANITIZED }}- | ||
| - name: Cache Ruby gems | ||
| uses: ./.github/actions/cache-bundler | ||
| - name: Set up Ruby |
Member
Author
There was a problem hiding this comment.
not super confident in this mobile e2e pass...but just want to get it working for the upgrade pr.
going to do a quick pass in a follow up pr. will save the ci finalization pass for you @remicolin
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (4)
.github/workflows/common-ci.yml (4)
12-19: Stop caching node_modules; pin Node 22 and tighten cache version for RN 0.76 migrationCaching node_modules across jobs leads to stale/ABI-mismatched native builds and non-deterministic lint/type behavior—especially during the RN 0.76 + Node 22 upgrade. Also, the workflow doesn’t pin Node 22, which can cause the same issues. Replace node_modules caching with Yarn’s immutable cache only, and encode the Node bump in cache-version (or include it in the key) so caches bust correctly when runtimes change.
Apply these diffs in each of the four “Cache Yarn dependencies” steps:
@@ - name: Cache Yarn dependencies uses: ./.github/actions/cache-yarn with: path: | .yarn/cache - node_modules - common/node_modules - cache-version: v1 + cache-version: rn-0.76-node22-v1Add Node setup right after checkout in each job (outside the selected range):
- name: Setup Node.js 22 and enable Corepack uses: actions/setup-node@v4 with: node-version: '22' cache: 'yarn' cache-dependency-path: | **/yarn.lock - run: corepack enableAlso applies to: 38-45, 58-65, 92-99
22-23: Gate cache save on actual build outputs to avoid poisoning cross-run cachesIf build:deps partially fails or yields empty dist folders, the subsequent cache save will store empty artifacts. Downstream jobs then “cache-hit,” skip rebuilds, and run with missing types/runtime code. Verify outputs exist and only save the cache when verification passes.
- name: Build dependencies run: yarn workspace @selfxyz/mobile-app run build:deps + + - name: Verify build outputs + id: verify-build + run: | + set -euo pipefail + test -d common/dist && [ -n "$(ls -A common/dist)" ] + test -d packages/mobile-sdk-alpha/dist && [ -n "$(ls -A packages/mobile-sdk-alpha/dist)" ] @@ - - name: Cache build artifacts - uses: actions/cache/save@v4 + - name: Cache build artifacts + if: steps.verify-build.outcome == 'success' + uses: actions/cache/save@v4 with: path: | common/dist packages/mobile-sdk-alpha/dist key: build-deps-${{ runner.os }}-${{ hashFiles('common/**/*', 'packages/mobile-sdk-alpha/**/*', '!common/dist/**', '!packages/mobile-sdk-alpha/dist/**') }}Optional but safer: use upload/download-artifact within this workflow run instead of cross-run caches to eliminate stale artifacts.
Also applies to: 27-30
69-69: Treat “cache-hit but missing/empty artifacts” as a miss in type-checkA restore success doesn’t guarantee valid contents. Add an integrity check and rebuild @selfxyz/common when artifacts are missing to prevent type-checks against empty dists.
- name: Restore build artifacts id: restore-build-deps uses: actions/cache/restore@v4 with: path: | common/dist packages/mobile-sdk-alpha/dist key: build-deps-${{ runner.os }}-${{ hashFiles('common/**/*', 'packages/mobile-sdk-alpha/**/*', '!common/dist/**', '!packages/mobile-sdk-alpha/dist/**') }} fail-on-cache-miss: false + + - name: Check build artifacts presence + id: check-artifacts + run: | + set -euo pipefail + missing=false + [ -d common/dist ] && [ -n "$(ls -A common/dist)" ] || missing=true + [ -d packages/mobile-sdk-alpha/dist ] && [ -n "$(ls -A packages/mobile-sdk-alpha/dist)" ] || missing=true + echo "missing=${missing}" >> "$GITHUB_OUTPUT" @@ - - name: Build @selfxyz/common (fallback on cache miss) - if: steps.restore-build-deps.outputs.cache-hit != 'true' + - name: Build @selfxyz/common (fallback or if artifacts missing) + if: steps.restore-build-deps.outputs.cache-hit != 'true' || steps.check-artifacts.outputs.missing == 'true' run: yarn workspace @selfxyz/common buildAlso applies to: 72-75, 78-78
103-103: Mirror the artifact integrity check in test-commonPrevent test runs against empty restored artifacts by rebuilding when dists are missing, same as type-check.
- name: Restore build artifacts id: restore-build-deps uses: actions/cache/restore@v4 with: path: | common/dist packages/mobile-sdk-alpha/dist key: build-deps-${{ runner.os }}-${{ hashFiles('common/**/*', 'packages/mobile-sdk-alpha/**/*', '!common/dist/**', '!packages/mobile-sdk-alpha/dist/**') }} fail-on-cache-miss: false + + - name: Check build artifacts presence + id: check-artifacts + run: | + set -euo pipefail + missing=false + [ -d common/dist ] && [ -n "$(ls -A common/dist)" ] || missing=true + [ -d packages/mobile-sdk-alpha/dist ] && [ -n "$(ls -A packages/mobile-sdk-alpha/dist)" ] || missing=true + echo "missing=${missing}" >> "$GITHUB_OUTPUT" @@ - - name: Build @selfxyz/common (fallback on cache miss) - if: steps.restore-build-deps.outputs.cache-hit != 'true' + - name: Build @selfxyz/common (fallback or if artifacts missing) + if: steps.restore-build-deps.outputs.cache-hit != 'true' || steps.check-artifacts.outputs.missing == 'true' run: yarn workspace @selfxyz/common buildAlso applies to: 106-109, 112-112
🧹 Nitpick comments (1)
.github/workflows/common-ci.yml (1)
27-30: Prefer same-run artifacts over cross-run caches for build outputsactions/cache is optimized for dependency caches, not compiled outputs. Using upload-artifact/download-artifact within the same workflow run avoids global cache pollution, simplifies keys, and guarantees consistency across jobs.
Example replacement (outside this range):
# In build job - name: Upload build artifacts uses: actions/upload-artifact@v4 with: name: build-deps-${{ github.sha }} path: | common/dist packages/mobile-sdk-alpha/dist # In type-check and test-common jobs - name: Download build artifacts uses: actions/download-artifact@v4 with: name: build-deps-${{ github.sha }} path: .
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/common-ci.yml(3 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-08-24T18:52:25.766Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.766Z
Learning: Use yarn scripts: yarn ios/android for builds, yarn test for unit tests, and Fastlane for deployments
Applied to files:
.github/workflows/common-ci.yml
📚 Learning: 2025-08-24T18:54:04.799Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-08-24T18:54:04.799Z
Learning: Applies to packages/mobile-sdk-alpha/package.json : Expose a 'test:build' script in the SDK's package.json that runs build, test, types, and lint
Applied to files:
.github/workflows/common-ci.yml
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: e2e-ios
- GitHub Check: analyze-android
- GitHub Check: run_circuit_tests
🔇 Additional comments (2)
.github/workflows/common-ci.yml (2)
80-81: Good: Decoupled build of @selfxyz/mobile-sdk-alphaBuilding the SDK unconditionally removes hidden coupling on common/dist cache hits and prevents missing-type failures later. Keep this.
114-115: Good: Always building @selfxyz/mobile-sdk-alpha before testsEnsures tests don’t run with stale/missing SDK outputs. This aligns with the earlier recommendation to avoid relying on common/dist cache hits.
* chore: speed up mobile e2e workflow * chore: disable android e2e job * chore: speed up ios build * fix: bundle js for ios debug build
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/mobile-e2e.yml (1)
183-193: Use setup-xcode outputs instead of hardcoding /Applications/Xcode_${XCODE_VERSION}.appThe action exposes the resolved Xcode path; switching via that output is more robust across runner image changes and naming differences. Add an id and switch to the output path.
- - name: Set up Xcode - uses: maxim-lobanov/setup-xcode@v1 + - name: Set up Xcode + id: setup-xcode + uses: maxim-lobanov/setup-xcode@v1 with: xcode-version: ${{ env.XCODE_VERSION }} - name: Configure Xcode path run: | echo "🔧 Configuring Xcode path to fix iOS SDK issues..." # Fix for macOS 15 runner iOS SDK issues # See: https://github.com/actions/runner-images/issues/12758 - sudo xcode-select --switch /Applications/Xcode_${{ env.XCODE_VERSION }}.app + sudo xcode-select --switch "${{ steps.setup-xcode.outputs.path }}" echo "✅ Xcode path configured"Reference: setup-xcode provides
outputs.pathandoutputs.version. (github.com)
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/mobile-e2e.yml(11 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-08-02T23:53:45.928Z
Learnt from: transphorm
PR: selfxyz/self#823
File: app/ios/Self.xcodeproj/project.pbxproj:320-332
Timestamp: 2025-08-02T23:53:45.928Z
Learning: When reviewing autogenerated scripts in Xcode project files (like React Native Firebase's embedded shell scripts), avoid suggesting edits since these are regenerated during pod install and cannot be manually modified by users.
Applied to files:
.github/workflows/mobile-e2e.yml
📚 Learning: 2025-08-24T18:52:25.766Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.766Z
Learning: Use yarn scripts: yarn ios/android for builds, yarn test for unit tests, and Fastlane for deployments
Applied to files:
.github/workflows/mobile-e2e.yml
📚 Learning: 2025-08-24T18:52:25.766Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.766Z
Learning: E2E testing with Maestro for platform-specific flows
Applied to files:
.github/workflows/mobile-e2e.yml
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: run_circuit_tests
- GitHub Check: e2e-ios
- GitHub Check: analyze-android
🔇 Additional comments (1)
.github/workflows/mobile-e2e.yml (1)
63-66: Good guardrails: fail fast when Maestro E2E files are missingThese checks prevent wasted CI minutes and produce actionable errors early. LGTM.
Also applies to: 168-171
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
.github/workflows/mobile-e2e.yml (3)
32-33: Keep Android build validation on; gate only emulator/tests.Disabling the whole job removes build-time regression coverage during a risky RN/AGP upgrade. Keep assemble running to catch Java/Kotlin/Gradle breakages, and disable only the emulator + Maestro steps until the disk issue is fixed.
Apply:
e2e-android: - if: false # Temporarily disable Android E2E until emulator disk issue resolved + # Keep build validation; gate only emulator/tests until emulator disk issue is resolved @@ - - name: Install and Test on Android + - name: Install and Test on Android + if: false # Temporarily disabled until emulator disk issue resolvedAlso applies to: 101-104
72-76: Pin Maestro installer to MAESTRO_VERSION for reproducible CI.Cache is keyed to MAESTRO_VERSION, but the install script currently fetches “latest,” creating drift. Pin the installer to the cached version.
- name: Install Maestro if: steps.cache-maestro.outputs.cache-hit != 'true' - run: curl -Ls "https://get.maestro.mobile.dev" | bash + env: + MAESTRO_VERSION: ${{ env.MAESTRO_VERSION }} + run: curl -Ls "https://get.maestro.mobile.dev" | bash -s -- --version "${MAESTRO_VERSION}"
176-181: Apply the same Maestro version pin on iOS.Mirror the Android fix to avoid cross-platform version skew.
- name: Install Maestro if: steps.cache-maestro.outputs.cache-hit != 'true' - run: curl -Ls "https://get.maestro.mobile.dev" | bash + env: + MAESTRO_VERSION: ${{ env.MAESTRO_VERSION }} + run: curl -Ls "https://get.maestro.mobile.dev" | bash -s -- --version "${MAESTRO_VERSION}"
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/mobile-e2e.yml(11 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-08-24T18:52:25.766Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.766Z
Learning: Use yarn scripts: yarn ios/android for builds, yarn test for unit tests, and Fastlane for deployments
Applied to files:
.github/workflows/mobile-e2e.yml
📚 Learning: 2025-08-02T23:53:45.928Z
Learnt from: transphorm
PR: selfxyz/self#823
File: app/ios/Self.xcodeproj/project.pbxproj:320-332
Timestamp: 2025-08-02T23:53:45.928Z
Learning: When reviewing autogenerated scripts in Xcode project files (like React Native Firebase's embedded shell scripts), avoid suggesting edits since these are regenerated during pod install and cannot be manually modified by users.
Applied to files:
.github/workflows/mobile-e2e.yml
📚 Learning: 2025-08-24T18:52:25.766Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.766Z
Learning: E2E testing with Maestro for platform-specific flows
Applied to files:
.github/workflows/mobile-e2e.yml
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: e2e-ios
- GitHub Check: analyze-android
- GitHub Check: run_circuit_tests
Comment on lines
+199
to
205
| - name: Set up Ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| path: app/vendor/bundle | ||
| lock-file: app/Gemfile.lock | ||
| cache-version: ${{ env.GH_CACHE_VERSION }}-${{ env.GH_GEMS_CACHE_VERSION }}-ruby${{ env.RUBY_VERSION }} | ||
| ruby-version: "3.3" | ||
| bundler-cache: true | ||
| working-directory: app | ||
| - name: Cache Pods |
Contributor
There was a problem hiding this comment.
🛠️ Refactor suggestion
ruby/setup-ruby: bundler-cache isn’t scoped to app/Gemfile (working-directory is ignored).
The action doesn’t support a working-directory input; bundler-cache will look in repo root, so gems won’t be cached/installed for app/Gemfile. This causes non-deterministic gem installs and slower pod steps.
Use BUNDLE_GEMFILE to scope bundler-cache:
- - name: Set up Ruby
- uses: ruby/setup-ruby@v1
- with:
- ruby-version: "3.3"
- bundler-cache: true
- working-directory: app
+ - name: Set up Ruby
+ uses: ruby/setup-ruby@v1
+ env:
+ BUNDLE_GEMFILE: app/Gemfile
+ with:
+ ruby-version: "3.3"
+ bundler-cache: true📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - name: Set up Ruby | |
| uses: ruby/setup-ruby@v1 | |
| with: | |
| path: app/vendor/bundle | |
| lock-file: app/Gemfile.lock | |
| cache-version: ${{ env.GH_CACHE_VERSION }}-${{ env.GH_GEMS_CACHE_VERSION }}-ruby${{ env.RUBY_VERSION }} | |
| ruby-version: "3.3" | |
| bundler-cache: true | |
| working-directory: app | |
| - name: Cache Pods | |
| - name: Set up Ruby | |
| uses: ruby/setup-ruby@v1 | |
| env: | |
| BUNDLE_GEMFILE: app/Gemfile | |
| with: | |
| ruby-version: "3.3" | |
| bundler-cache: true | |
| - name: Cache Pods |
🤖 Prompt for AI Agents
.github/workflows/mobile-e2e.yml lines 199-205: the ruby/setup-ruby step is
using bundler-cache but working-directory is ignored so bundler-cache looks at
repo root; set BUNDLE_GEMFILE to scope bundler-cache to app/Gemfile and ensure
subsequent steps use that Gemfile. Update the ruby/setup-ruby step to include an
env mapping BUNDLE_GEMFILE: app/Gemfile (or export BUNDLE_GEMFILE before running
the action), remove reliance on working-directory for bundler-cache, and confirm
later pod/install steps run with the same BUNDLE_GEMFILE or explicitly run in
the app directory.
This was referenced Aug 30, 2025
remicolin
added a commit
that referenced
this pull request
Sep 22, 2025
* SDK Go version (#920) * feat: helper functions and constant for go-sdk * feat: formatRevealedDataPacked in go * chore: refactor * feat: define struct for selfBackendVerifier * feat: verify function for selfBackendVerifier * feat(wip): custom hasher * feat: SelfVerifierBacked in go * test(wip): scope and userContextHash is failing * test: zk proof verified * fix: MockConfigStore getactionId function * chore: refactor * chore: remove abi duplicate files * chore: move configStore to utils * chore: modified VcAndDiscloseProof struct * chore: more review changes * feat: impl DefaultConfig and InMemoryConfigStore * chore: refactor and export functions * fix: module import and README * chore: remove example folder * chore: remove pointers from VerificationConfig * chore: coderabbit review fixes * chore: more coderabbit review fix * chore: add license * fix: convert attestationIdd to int * chore: remove duplicate code --------- Co-authored-by: ayman <[email protected]> * Moving proving Utils to common (#935) * remove react dom * moves proving utils to the common * need to use rn components * fix imports * add proving-utils and dedeuplicate entry configs for esm and cjs. * must wrap in text component * fix metro bundling * fix mock import * fix builds and tests * please save me * solution? * fix test * Move proving inputs to the common package (#937) * create ofactTree type to share * move proving inputs from app to register inputs in common * missed reexport * ok * add some validations as suggested by our ai overlords * Fix mock passport flow (#942) * fix dev screens * add hint * rename * fix path * fix mobile-ci path * fix: extractMRZ (#938) * fix: extractMRZ * yarn nice && yarn types * fix test: remove unused * fix mobile ci * add script --------- Co-authored-by: Justin Hernandez <[email protected]> * Move Proving attest and cose (#950) * moved attest and cose utils to common with cursor converted tests in common to use vitest and converted coseVerify.test to vitest after moving from app to common what does cryptoLoader do? * moved away * get buff Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * SELF-253 feat: add user email feedback (#889) * feat: add sentry feedback * add sentry feedback to web * feat: add custom feedback modal & fix freeze on IOS * yarn nice * update lock * feat: show feedback widget on NFC scan issues (#948) * feat: show feedback widget on NFC scan issues * fix ref * clean up * fix report issue screen * abstract send user feedback email logic * fixes * change text to Report Issue * sanitize email and track event messge * remove unnecessary sanitization * add sanitize error message tests * fix tests * save wip. almost done * fix screen test * fix screen test * remove non working test --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> * chore: centralize license header checks (#952) * chore: centralize license header scripts * chore: run license header checks from root * add header to other files * add header to bundle * add migration script and update check license headers * convert license to mobile sdk * migrate license headers * remove headers from common; convert remaining * fix headers * add license header checks * update unsupported passport screen (#953) * update unsupported passport screen * yarn nice * Migrate Analytics (#951) * setup analytics adapter for self mobile sdk client and use in app * wrap for context * fix build * yarn types is an alias for build when build just compiles ts * ok unlock * deeper * ok this looks to work * fix license check * make sure it starts with this line * someone didnt commit * fix double analytics bug and builds * lint * Read document catalog from selfClient (#936) * [SELF-676] feat: upgrade React Native from 0.75.4 to 0.76.9 (#943) * chore: upgrade build tooling to Node 22 and AGP 8.6 * chore: upgrade react-native to 0.76.9 * update lock files and formatting * fix path * fix: handle hermes-engine cache mismatch in CI after React Native upgrade - Add fallback logic to run 'pod update hermes-engine' when pod install fails - This resolves CocoaPods cache issues that occur after React Native version upgrades - Fixes CI pipeline failures on codex/update-core-tooling-for-react-native-upgrade branch * fix: improve hermes-engine cache handling in CI - Preemptively clear CocoaPods cache before pod install - This prevents dependency analysis failures that occur when cached podspecs conflict - Addresses the root cause: cache conflicts during 'Analyzing dependencies' phase - Keeps fallback logic for additional safety * fix: handle hermes-engine cache in mobile-bundle-analysis workflow - Add pod-install-with-cache-fix.sh script to handle hermes-engine cache conflicts - Update install-app:setup script to use the new cache fix approach - This fixes the mobile-bundle-analysis.yml workflow failures after React Native upgrade - Proactively clears CocoaPods cache and has fallback for hermes-engine updates * formatting * fix: robust hermes-engine cache handling in CI workflows - Apply comprehensive cache clearing to mobile-ci.yml and mobile-e2e.yml - Pre-emptively run 'pod update hermes-engine' before pod install - Clear multiple cache locations to handle CI environment differences - This prevents 'hermes-engine differs from Pods/Local Podspecs' errors - Fixes all workflows affected by React Native 0.76.9 upgrade cache issues * fixes * clean up * update lock files * fix tests * sort * fixes * fix ci * fix deployment target * android fixes * upgrade fix * fixes * fix: streamline mobile CI build and caching (#946) * fix: streamline mobile CI build and caching * Enable mobile E2E tests on codex/fix-mobile-ci-workflow-errors branch * test * simplify and fix path * workflow fixes * fix loading on 0.76.9 * clean up unnecessary comments * fix readme * finalize upgrade to 0.76.9 * fix android build and upgrade * fix bundler caching * download cli to fix "yarn start" issues * fix cli build erorr * fix script path * better path * abstract build step to prevent race condition * fixes * better cache * fix corepack build error * update lock * update lock * add yarn cache to workflows * fix test building * ci caching improvements * fix common type check * fix common ci * better mobile sdk alpha building logic * chore: speed up mobile e2e workflow (#962) * chore: speed up mobile e2e workflow * chore: disable android e2e job * chore: speed up ios build * fix: bundle js for ios debug build * fix e2e * fix mobile ci (#964) * feat: improve mixpanel flush strategy (#960) * feat: improve mixpanel flush strategy * fixes * fix build * update lock * refactor methods * conslidate calls * update package and lock * refactor: remove namespace imports (#969) * refactor: remove namespace imports * refactor: use named fs imports * refactor(app): replace path and fs namespace imports * format * format * Mixpanel tweaks (#971) * udpates * fox * update license * Add DSC parsing check (#836) * Handle missing dsc parsed * nice * fix test * throw * fix * chore(app): upgrade dependencies (#968) * chore(app): upgrade dependencies * update package * update lock files * fixes * lock * fix * Auth Adapter + (#958) * basic auth adapater * remove SelfMobileSDk, this was another architecture which the adapter patern replaced * rename to avoid confusion with client.test.ts * basic auth adapater * remove SelfMobileSDk, this was another architecture which the adapter patern replaced * rename to avoid confusion with client.test.ts * self * fix * remove prototypes * make sure its mounted * fix tests * fmt * require required adapters * fix types * not a partial * adds missing exports * fix missing data * Fix nfc configuration scanning issue (#978) * fix nfc scanning on ios and android * save test * fix tests * fix lint * Chore fix ios nfc scanning and compiling (#979) * fixes * silence error * fix debugge * fix nfc scanning * lint and pipeline fixes * large runner (#980) * chore: update to macos latest large runner (#981) * bump up to macos-latest-large * fix ci * Move loadSelectedDocument to SDK (#967) Co-authored-by: Aaron DeRuvo <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * docs: update mobile SDK migration progress (#982) * docs: record app integration progress * docs: consolidate mobile SDK migration tracking * docs: humanize migration tracking and merge prompts * docs: add common consolidation tasks * docs: reprioritize migration tasks * docs: soften migration plan tone * docs: detail agent prompts with file paths * docs: catalog Linear tasks for SDK * updates * remove artifact management * moves validateDocument functions into the common package. (#977) * moves validateDocument functions into the common package. * fix build issues and lint * handle bad connections better in nullifiier * add an abort controler to nullifer fetcher, ignore fals positives * import types separately * take it as an arg * chore: update yarn.lock * chore(app): resolve lint warnings (#990) * chore(app): resolve lint warnings * update lock * clean up any types * fix types * feedback from cr * [SELF-703] feat: Migrate mock generator to mobile sdk (#992) * feat: expose mock generator * formatting * fix tests and lint * rename passport to document * fix types * [SELF-698] scaffold mobile sdk demo app (#993) * chore: scaffold mobile sdk demo app * test: cover demo app menu * prettier and types * sort * add android app foundation * fix android loading * get ios app running * update script * cr feedback * disable fabric * fixes * fixes * fix * SELF-702: Refactor navigation structure and dev utilities (#994) * Refactor navigation and dev screens * refactor: rename passport screens to document * fixes * add missing header * fixes * type files * feat: clarify proof verification analytics (#996) * feat: increase sha256 byte size and add new rsa circuits (#986) * feat: increase sha256 byte size and add new rsa circuits * feat: modularise the rsa fp pow mod * chore: comment signature verifier for testing * fix: sha256_sha256_sha224_ecdsa_secp224r1 * lint * chore: implement google play suggestions (#997) * google play suggestions * update gitguardian ignore * remove unused * chore: address yarn lock issues (#1004) * address yarn lock issues * fix postinstall * skip postinstall for ci (#1005) * [SELF-654] feat: add native modules (#919) * feat: add ios native modules * fix: extractMRZ * Add android OCR native module * wire native mrz module with adapter * wire Native modules and fix tests * fixes * fix license header logic * fix tests * fix types * fix: ci test * fix: android build ci * fix: ios build CI * add podfile.lock * add yarn.lock * update lock files * add yarn.lock * add license * order methods * update lock * pipeline fixes * prettier * update lock file * fix native modules on external apps * bundle @selfxyz/common into mobile-sdk-alpha * chore: address yarn lock issues (#1004) * address yarn lock issues * fix postinstall * update lock * fix build issues * fix pipeline issue * fix ci * fix bad merge * fix android ci * fix ci errors * fix mobile sdk ci. stop gap fix for now until we create a package * tweaks * retry aapt2 approach * use ^0.8.4 instead of ^0.8.0 due to the use of custom errors * workflow fixes * fix file * update * fix ci * test ci fix * fix test --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> * chore: update dev with staging 09/06/25 (#1007) * update CI * bump iOS version * update readme * update mobile-deploy ci * bump version iOS * update workflow to use workload identity federation (#933) * update workflow to use workload identity federation * add token permissions * correct provider name * chore: incrementing android build version for version 2.6.4 [github action] --------- Co-authored-by: Self GitHub Actions <[email protected]> * update ci * update ci * update ci * update ci * update ci * fix ci * fix ci * fix ci * remove fastlane use for android * bump iOS build version * update CI python script * iterate on CI * iterate on CI * iterate on CI * Dev (#941) * SDK Go version (#920) * feat: helper functions and constant for go-sdk * feat: formatRevealedDataPacked in go * chore: refactor * feat: define struct for selfBackendVerifier * feat: verify function for selfBackendVerifier * feat(wip): custom hasher * feat: SelfVerifierBacked in go * test(wip): scope and userContextHash is failing * test: zk proof verified * fix: MockConfigStore getactionId function * chore: refactor * chore: remove abi duplicate files * chore: move configStore to utils * chore: modified VcAndDiscloseProof struct * chore: more review changes * feat: impl DefaultConfig and InMemoryConfigStore * chore: refactor and export functions * fix: module import and README * chore: remove example folder * chore: remove pointers from VerificationConfig * chore: coderabbit review fixes * chore: more coderabbit review fix * chore: add license * fix: convert attestationIdd to int * chore: remove duplicate code --------- Co-authored-by: ayman <[email protected]> * Moving proving Utils to common (#935) * remove react dom * moves proving utils to the common * need to use rn components * fix imports * add proving-utils and dedeuplicate entry configs for esm and cjs. * must wrap in text component * fix metro bundling * fix mock import * fix builds and tests * please save me * solution? * fix test * Move proving inputs to the common package (#937) * create ofactTree type to share * move proving inputs from app to register inputs in common * missed reexport * ok * add some validations as suggested by our ai overlords * Fix mock passport flow (#942) * fix dev screens * add hint * rename * fix path * fix mobile-ci path * fix: extractMRZ (#938) * fix: extractMRZ * yarn nice && yarn types * fix test: remove unused * fix mobile ci * add script --------- Co-authored-by: Justin Hernandez <[email protected]> * Move Proving attest and cose (#950) * moved attest and cose utils to common with cursor converted tests in common to use vitest and converted coseVerify.test to vitest after moving from app to common what does cryptoLoader do? * moved away * get buff Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * SELF-253 feat: add user email feedback (#889) * feat: add sentry feedback * add sentry feedback to web * feat: add custom feedback modal & fix freeze on IOS * yarn nice * update lock * feat: show feedback widget on NFC scan issues (#948) * feat: show feedback widget on NFC scan issues * fix ref * clean up * fix report issue screen * abstract send user feedback email logic * fixes * change text to Report Issue * sanitize email and track event messge * remove unnecessary sanitization * add sanitize error message tests * fix tests * save wip. almost done * fix screen test * fix screen test * remove non working test --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> * chore: centralize license header checks (#952) * chore: centralize license header scripts * chore: run license header checks from root * add header to other files * add header to bundle * add migration script and update check license headers * convert license to mobile sdk * migrate license headers * remove headers from common; convert remaining * fix headers * add license header checks * update unsupported passport screen (#953) * update unsupported passport screen * yarn nice --------- Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: ayman <[email protected]> Co-authored-by: Aaron DeRuvo <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * bump version * bump yarn.lock * update ci (#966) * chore: Manually bump and release v2.6.4 (#961) * update lock files * bump and build android * update build artifacts * show generate mock document button * update lock * fix formatting and update failing e2e test * revert podfile * fixes * fix cold start of the app with deeplink * update ci * update ci * Sync MARKETING_VERSION to iOS project files after version bump * chore: incrementing android build version for version 2.6.4 [github action] (#976) Co-authored-by: remicolin <[email protected]> * chore: add build dependencies step for iOS and Android in mobile deploy workflow * chore: enhance mobile deploy workflow by adding CMake installation step * bump android build version * chore: incrementing android build version for version 2.6.4 [github action] (#985) Co-authored-by: remicolin <[email protected]> * chore: configure Metro bundler for production compatibility in mobile deploy workflow * chore: incrementing android build version for version 2.6.4 [github action] (#987) Co-authored-by: remicolin <[email protected]> * Revert "chore: configure Metro bundler for production compatibility in mobile deploy workflow" This reverts commit 60fc1f2580c2f6ad3105d8b904d969412a18bd2e. * reduce max old space size in mobile-deploy ci * fix android french id card (#957) * fix android french id card * fix common ci cache * feat: log apdu (#988) --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> * unblock ci * fix merge * merge fixes * fix tests * make ci happy --------- Co-authored-by: turnoffthiscomputer <[email protected]> Co-authored-by: pputman-clabs <[email protected]> Co-authored-by: Self GitHub Actions <[email protected]> Co-authored-by: turnoffthiscomputer <[email protected]> Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: ayman <[email protected]> Co-authored-by: Aaron DeRuvo <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: fix yarn format (#1009) * fix yarn format * yarn format * fix lint * undo temporary disabling * pipeline fixes * revert nvmrc change * add new home screen (#1019) * add new home screen * fix typing issue * yarn nice * chore: update the cpp build script (#1021) * chore: install node (#1022) * chore: use node v22 (#1023) * chore: install yarn (#1024) * chore: yarn cache (#1025) * chore: sanitise node version (#1026) * remove lazy loading (#1018) * remove lazy loading * fix tests * formatting * fix imports and web ci * fix tests * fix building * fix * debug ci * fix web ci issue * fix * fix * fix ci * remove web render test * coderabbit feedback * fix ci * use import * fix lint * fix compiling * update lock * update lock * fix: update yarn.lock hash for @selfxyz/mobile-sdk-alpha Resolves CI error where yarn install --immutable failed due to outdated package hash. The hash changed from b2afc4 to f9ebb9. * fix: update yarn.lock hash after mobile-sdk-alpha changes - Hash changed from c0e6b9 to 0d0f72 due to package modifications - Cleaned caches and regenerated lockfile to ensure consistency - This resolves CI cache mismatch where old artifacts had stale hash * fix: update yarn.lock hash after building mobile-sdk-alpha - Final hash: 89f5a6 (includes built dist artifacts) - Built mobile-sdk-alpha to ensure package is in stable state - This should resolve CI immutable install errors * fix yarn lock and build * chore(ci): improve mobile e2e caching (#1010) * chore(ci): improve mobile e2e caching * chore(ci): restore deriveddata cache * chore(ci): remove ios deriveddata cache * chore(ci): cache ios derived data * chore(ci): optimize mobile deploy caching * chore(ci): enable ccache for ios e2e builds * fix(ci): add ccache path for ios e2e * moves ofac and protocol store (#1012) * move ofact tree fetch to common * move protocol store to the msdk, fix some dependencies on msdk * chore: remove register id from register circuits (#1028) * chore: remove register id from register circuits * chore: only use 128ram instance * Feat/build cpp (#1029) * chore: remove register id from register circuits * chore: only use 128ram instance * chore: build 2 circuits at a time * Remove navigationRef from provingMachine (#1011) * SDK: minimize amount of data sent through PROVING_PASSPORT_NOT_SUPPORTED event (#1030) * Fix mock passport generation (#1031) * fix mock passport generation * fix mobile ci tests * Feat/aadhaar (#949) * make contract sdk simpler (#514) * make contract sdk simpler * reduce root inputs * delete convert function * summarize our library * update npm package * update package version * update attestation id * add util function to get revealed data * Revert "make contract sdk simpler (#514)" (#518) This reverts commit 847b88d5ecc0d449b976a552f68af38eec8e561b. * merge dev into main (#576) * Feat: Show error code in SDK (#500) * feat: emit `error_code` and `reason` in app * feat: add `onError` in sdk * feat: Display reason in app * lint & fmt * feat: add scrollview in ProofRequestStatusScreen for long reasons * Fix input generation for 521bit curves (#481) * fix EC point padding for 521 bit curves * rename modulus to point in findStartIndexEC as it is a point * simplify matching logic * simplify padding logic * remove comment * remove log removing .only so the CI/CD runs circuit tests fix disclosure test fix scope in test fix scope error in circuit tests remove .only fix test * run ci/cd * Feat/simpler contract sdk (#519) * make contract sdk simpler * reduce root inputs * delete convert function * summarize our library * update npm package * update package version * update attestation id * add util function to get revealed data --------- Co-authored-by: motemotech <[email protected]> * forgot to include package update (#521) * Bump version to 2.5.1 (#522) * bump version * update fastlane * fix bump version * bump build and add todo * disable commit for now * [SEL-154] Step 1: Scan your passport (#511) * simplify navigation logic * use aesop design hook * save wip * add new aesop redesign screens * save wip design * refactor nav bar logic * fix paths * save wip * stub progress navbar and save wip * save wip progress bar animation * save wip progress bar, almost done with design * fix progress bar design * fix bottom padding * disable git commit for now * fix flaky android downloads that causes pipeline to crash * update lock for ci * [SEL-46] FE: Add minimum bottom padding (#510) * fix bottom padding for smaller screens * fix podfile post install hook permissions check * update pod lock and disable git commit action step for now * update lock * fix flaky android downloads that causes pipeline to crash * fix: improve error handling for forbidden countries list mismatch (#494) * Update SelfBackendVerifier.ts * Update constants.ts * Update formatInputs.ts * Update formatCallData.ts * DX: Auto format on save (#526) * save wip * use elint instead of prettier to sort imports * set imports to warn * sync prettier settigns * update prettier settings * save working version * fix export and disable mobile pipeline for now * limit auto formatting to the app folder * remove artefacts * SEL-187: Make bottom layout scrollable on smaller screens (#525) * fix design check * add an option to disable local sending of sentry events * better sentry enable / disable * fix scan passport height * make bottom layout scrollable so it doesn't squish top screen * simpler logic check. don't create new env var * fix internet connection issues * readd comment * use isConnected instead of internet reachable * use a dynamic bottom panel height * add missing recovery screens * move aesop below * remove dupe export * fix rebase * fix android package download issue * Feat/extend id support (#517) * refactor proving impleting xstate, speedup proving * add disclosure proof support * keep refactoring provingMachine, clean old implementation * call init method when switching from dsc to register * rebase with dev to display why the proof verification failed * refactor ws connexion between front-end and mobile to retrieve self-app * update the webclient at proofVerification and use selfAppStore in provingMachine * fix provintStore.init in ProveScreen * yarn nice * fetch data correctly in splash screen * Bump build versions for 2.5.1 (#531) * release new builds * fix app and build versions * fix env check * display error animation on failure on loading screen (#532) * display error animation on failure on loading screen * remove log --------- Co-authored-by: Justin Hernandez <[email protected]> * ci: bump actions/checkout to v4 (#529) * make contract sdk simpler (#514) * make contract sdk simpler * reduce root inputs * delete convert function * summarize our library * update npm package * update package version * update attestation id * add util function to get revealed data * Revert "make contract sdk simpler (#514)" (#518) This reverts commit 847b88d5ecc0d449b976a552f68af38eec8e561b. * ci: bump actions/checkout to v4 --------- Co-authored-by: nicoshark <[email protected]> Co-authored-by: turnoffthiscomputer <[email protected]> * fix italy (#530) * Fix/proving machine endpoint type (#538) * store endpoint type in proving machine * yarn nice * fix splash screen error (#539) * New bug fix build for v2.5.1 (#540) * bump new build for dev fixes * update lock * reinstall before running local deploy * SEL-178: Improve haptic feedback library (#535) * fix dev settings typing * add dev screens file * save haptic feedback progress * change ordedr * fix initial route and add haptic feedback screen to dev settings options * add delete scripts (#542) * update staging registry address (#545) * feat: Add Disclose history (#533) * feat: Add Disclose history * fix: Duplicate history in list * fix: Outdated disclosures * Delete app/ios/Self copy-Info.plist * allow a scale of up to 1.3 (#546) * allow a scale of up to 1.3 * update lock files * clean up unused imports * fix settings * add common sdk (#537) * add common sdk * remove sdk backend api * remove registry * regenerate sha256 rsa dsc each time * download ski-pem dynamically on staging, refactor initpassportDataParsing * add state machine for button on prove screen, improve ux on splash screen * fetch ski-pem in production * fix linter issues * fix prove screen button bugs * update podfile.lock and yarn.lock * run linter in circuits repo * bump build * bump version for sentry debugging * bump ios to version 118 --------- Co-authored-by: Justin Hernandez <[email protected]> * better connection check (#548) * Clean up navigation and setup Jest (#549) * remove dupe account screens and prefer the term home * organize screen loading better * sort keys * rename screen files wip * fix deleted directory issues * rename folders * fix paths and naming * save working jest import test * save base working jest navigation test * finalize navigation refactor and jest test * update test name and podfile lock * remove unused packages * use the correct version of react test renderer * bump build (#552) * Eth dublin (#554) * add mock id card generator * add genMockIdDoc in common/sdk exports * onboard developer id using deeplink, allow custom birthdate on mockpassport * log more dsc info (#558) * Push notification (#536) * add push notification feature * merge new app impl * change dsc key * import * reverse mock dsc * worked in the ios * checked in android * update url and delete console * delete small changes * lint * add yarn.lock * fix warning message * add mock notification service for test code * fix path for the mock implementation * add mock deeplink to the test code * nice notificationServiceMock.js * delete unused firebase related implementation * fix wording and UI related to notification service * hotfix on mockdatascreen --------- Co-authored-by: turnoffthiscomputer <[email protected]> * Fix deeplink 2 (#560) * fix deeplink * fix deeplink * yarn nice * feat: Use vision for MRZ scanning (SEL-47) (#557) * feat: Use vision for MRZ scanning * modify label to position the smartphone during the OCR scan --------- Co-authored-by: turnoffthiscomputer <[email protected]> * SEL-255: improved loading screen with estimated wait times (#550) * create new loading screen and rename static to misc * fix route * save wip loading screen * save wip animation * save static wip design * continue * splash * add a loading screen text helper * add test for loading screen text * save wip. almost there * update haptic logic * better feedback and add dev scren * save current work * update text logic and tests * load passport metadata in loading screen * simplify and fix tests * test for additional exponents * add new animation * rename file * consolidate ui useEffect and fix loading screen layout * fix current state * remove mockPassportFlow param * merge new loading screen and new notification logic * simplify * update lock * use passportMetadata instead of metadata * save simplification * update loading text based on pr feedback and tests * Bump v2.5.1: ios 122; android 60 (#561) * increment build to 120 * bump builds for 2.5.1. ios 121; android 60 * clean up logic * upgrade react native firebase for privacy manifests * update react native keychain to fix could not recover issue (#564) * fix: update ocr corrections (#563) * Chore: Polish proof history to prep for release (#566) * clean up nav and home boundaries, passport data screen insets * migrate proof history screen out of settings * minor clean up * save wip * add new ibm plex mono font and clean up proof detail screen * remove test data * remove extra loading screen text * remove unnecessary ceil * Bump v2.5.1; ios 123; android 62 (#565) * bump to build 61 * bump ios version * update version * Feature/add prettier formatter (#568) * Add Prettier configuration and ignore files for code formatting - Created .prettierignore to exclude specific directories and files from formatting. - Added .prettierrc.yml with custom settings for print width and trailing commas. - Updated package.json to include Prettier and its Solidity plugin as dependencies, along with scripts for formatting and checking code. * Run prettier formatting * fix nationality using mock passports * SEL-181 & SEL-252: Update mobile app events (#570) * improve analytics handling * add error boundary that flushes segment events before error occurs * upgrade segment analytics package * flush analytics when user encounters error screen * track all click events * add tracking to loading screen * better init and click event names * track cloud backup and modal actions * use __DEV__ for debugging * add tracking to account recovery, auth, mock data * return false instead of throwing * add more tracking events * save wip event updating * abstract analytic event names * update click events * clean up * move reasons comment * add unsupported passport event * Feature/enhance self verification root (#569) * Add SelfVerificationConsumer contract for self-verification logic - Introduced an abstract contract, SelfVerificationConsumer, that extends SelfVerificationRoot. - Implemented nullifier tracking, verification success events, and customizable validation and update methods for nullifiers. - Added error handling for nullifier check failures and hooks for derived contracts to implement custom logic after successful verification. * Add SelfHappyBirthday contract example using SelfVerificationConsumer - Introduced SelfHappyBirthday contract that allows users to claim USDC on their birthday. - Integrated SelfVerificationConsumer for handling verification and nullifier tracking. - Added functions to set claimable amount and window, along with event emissions for state changes. - Implemented logic to check if the claim is within the user's birthday window and transfer USDC accordingly. * Refactor imports in HappyBirthday contract for better organization - Updated import statements in HappyBirthday.sol to use relative paths for ISelfVerificationRoot, SelfCircuitLibrary, and SelfVerificationConsumer. - Improved code readability and maintainability by organizing imports more logically. * Refactor Airdrop contract to use SelfVerificationConsumer for registration logic - Updated Airdrop contract to inherit from SelfVerificationConsumer instead of SelfVerificationRoot. - Refactored mappings for user identifiers and nullifiers for improved clarity and functionality. - Enhanced error handling and updated function parameters for consistency. - Implemented new validation and update methods for nullifiers, streamlining the registration process. - Removed deprecated verifySelfProof function and integrated logic into new methods. * Add events and refactor SelfVerificationRoot and related contracts - Introduced new events in SelfVerificationRoot for verification configuration updates, scope changes, and attestation ID management. - Updated Airdrop contract to remove deprecated events and added a new event for Merkle root updates. - Refactored SelfPassportERC721 to inherit from SelfVerificationConsumer, enhancing verification logic and event handling. - Improved function parameters for consistency and clarity across contracts. * Refactor contracts to use SelfVerificationRoot and enhance verification logic - Removed SelfVerificationConsumer contract and updated related contracts to inherit from SelfVerificationRoot. - Refactored mappings and event emissions in Airdrop, HappyBirthday, and SelfPassportERC721 for improved clarity and functionality. - Enhanced verification success hooks to include user identifiers and nullifiers for better tracking. - Updated constructor parameters for consistency across contracts and improved error handling for user registration and claims. * Refactor constructor in SelfPassportERC721 for improved readability * Refactor function parameters in SelfVerificationRoot and related contracts * Refactor constructor parameter names in IdentityVerificationHub, Airdrop, IdentityRegistry, and ProxyRoot contracts for improved clarity and consistency * fix getCircuitName function (#575) * fix getCircuitName function * fix getCircuitName function * feat: Read ID cards (#571) * Update GitHub checkout action from v3 to v4 (#544) * Bump build version 2.5.2 to test react native keychain (#572) * bump build and version * bump version 2.5.2 * don't downgrade react native keychain * update app/README.md toolchain instructions (#140) * bump build (#580) --------- Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: turboblitz <[email protected]> Co-authored-by: motemotech <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: crStiv <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: James Niken <[email protected]> Co-authored-by: Kevin Lin <[email protected]> Co-authored-by: leopardracer <[email protected]> Co-authored-by: Olof Andersson <[email protected]> * feat(wip): register circuit for aadhaar * chore: add anon aadhar circuits * chore: remove sc and disclose selfrica test * feat: extract aadhaar qr data * test: aadhaar qr data extract circuit * test: aadhaar register circuit * feat: extract pincode and ph no last 4 digit * fix: register aadhaar nullifier and commitment * test: Verify commitment circuit of aadhaar * feat: add photoHash inside commitment * feat: build Aadhaar OFAC SMT * feat: ofac check and reveal data (test done) * test: qr extractor for custom data input * feat: add state as reveal data inside VC and disclose * chore: add comments * fix: num2Ceil component * chore: review changes * chore: use passport SignatureVerifier * fix: signatureVerifier inputs * feat: extract ascii values of fields * feat: provide users the flexibility to reveal specific characters of a field * chore: refactor * test: register aadhaar for tampered data * test(wip): should return 0 if in ofac list * test: ofac check * test: register aadhaar circuit for different qr data * merge dev into main (#683) * remove sdk/tests (#622) * remove sdk/tests * chore: update yarn.lock --------- Co-authored-by: Ayman <[email protected]> * fix: add range check on paddedInLength of shaBytesDynamic (#623) * fix ci (#626) * implement self uups upgradeable (#592) * implement self uups upgradeable * small changes in identityVerificationHubImplV2 * delete aderyn.toml * chore: add custom verifier * chnage return output * feat: use self structs and a Generic output struct * feat: add userIdentifier, nullifier, forbiddencountries to returned output * add root view functions from registry * fix: build and compilation errors * add userDefined data into selfVerificationRoot * "resolve conflicts" * fix compilation problem * fix how to register verification config * test: CustomVerifier * fix verification root and hub integration * add scope check in hub impl * replace poseidon hash to ripemd+sha256 * add todo list * feat: refactor and add test cases for generic formatter * add performUserIdentifierCheck in basicVerification * change how to handle additionalData and fix stack too deep * start adding test codes * fix dependency problems in monorepo * fix: forbidden countries (#612) LGTM! * able to run test code * pass happy path * delete unused codes * change error code name, add caller address validation and add scripts to run test and build in monorepo * add all test cases in vcAndDisclose flow * remove comment out * chore: use actual user identifier outputs * success in registration tests * cover all cases * pass contractVersion instead of circuitVersion * fix disclose test * chore: add natspecs for ImplHubV2, CustomVerifier and GenericFormatter * change val name and remove unused lines * add val name change * remove userIdentifier from return data * feat: use GenericDiscloseOutput struct in verfication hook fix test cases for user identifier * chore: change the function order for Hub Impl V2 (#625) * fix nat specs * add nat spec in SelfStructs --------- Co-authored-by: Ayman <[email protected]> Co-authored-by: Nesopie <[email protected]> * prettier (#629) * CAN auth - android (#613) * add missed files * add NFCMethodSelectionScreen * bump android build --------- Co-authored-by: Justin Hernandez <[email protected]> * feat: add MRZ correction method to NFCMethodSelectionScreen (#627) * add npm auth token env (#632) * bump sdk version (#633) * publish npm package when merging on dev * bump common sdk version * replace yarn publish by npm publish * update common package version * Simplify dev mode gesture (#635) * Simplify developer mode gesture * Enable dev mode on MockData screen with five taps * add build smt function to common sdk * update vc_and_disclose_id test (dev branch) (#641) * fix: vc_and_disclose_id test * chore: yarn prettier * Show modal on NFC scan error (#642) * Add help button and error modal actions * fix the screen management * yarn nice * Bump build v2.5.4: ios 132; android 71 (#631) * bump version and build numbers * remove tamagui/toast * fix marketing version * fix: update TD1 and TD3 checks (#643) * bum yarn.lock * Bump build: ios 133; android 72 and build fixes (#654) * update gesture version and bump android build * bump and fix ios build * update lock files * fixes * fix fotoapparat library source * Update example contracts to include EUID usage (#656) * refactor: update HappyBirthday contract to V2 with support for E-Passport and EUID cards, introduce bonus multipliers, and enhance verification logic * refactor: update Airdrop contract to V2 with support for E-Passport and EU ID Card attestations * refactor: remove BASIS_POINTS constant from Airdrop contract * feat: introduce SelfIdentityERC721 contract for issuing NFTs based on verified identity credentials, replacing SelfPassportERC721 * fix: update verification functions in Airdrop, HappyBirthday, and SelfIdentityERC721 contracts to use customVerificationHook * cherry pick commit from add-test-self-verification... * block non-dev pr to main branch * audit fixes (#645) * merge dev branch into main (#624) * remove sdk/tests (#622) * remove sdk/tests * chore: update yarn.lock --------- Co-authored-by: Ayman <[email protected]> * fix: add range check on paddedInLength of shaBytesDynamic (#623) * fix ci (#626) --------- Co-authored-by: Ayman <[email protected]> Co-authored-by: Vishalkulkarni45 <[email protected]> * update contracts (#628) * remove sdk/tests (#622) * remove sdk/tests * chore: update yarn.lock --------- Co-authored-by: Ayman <[email protected]> * fix: add range check on paddedInLength of shaBytesDynamic (#623) * fix ci (#626) * implement self uups upgradeable (#592) * implement self uups upgradeable * small changes in identityVerificationHubImplV2 * delete aderyn.toml * chore: add custom verifier * chnage return output * feat: use self structs and a Generic output struct * feat: add userIdentifier, nullifier, forbiddencountries to returned output * add root view functions from registry * fix: build and compilation errors * add userDefined data into selfVerificationRoot * "resolve conflicts" * fix compilation problem * fix how to register verification config * test: CustomVerifier * fix verification root and hub integration * add scope check in hub impl * replace poseidon hash to ripemd+sha256 * add todo list * feat: refactor and add test cases for generic formatter * add performUserIdentifierCheck in basicVerification * change how to handle additionalData and fix stack too deep * start adding test codes * fix dependency problems in monorepo * fix: forbidden countries (#612) LGTM! * able to run test code * pass happy path * delete unused codes * change error code name, add caller address validation and add scripts to run test and build in monorepo * add all test cases in vcAndDisclose flow * remove comment out * chore: use actual user identifier outputs * success in registration tests * cover all cases * pass contractVersion instead of circuitVersion * fix disclose test * chore: add natspecs for ImplHubV2, CustomVerifier and GenericFormatter * change val name and remove unused lines * add val name change * remove userIdentifier from return data * feat: use GenericDiscloseOutput struct in verfication hook fix test cases for user identifier * chore: change the function order for Hub Impl V2 (#625) * fix nat specs * add nat spec in SelfStructs --------- Co-authored-by: Ayman <[email protected]> Co-authored-by: Nesopie <[email protected]> * prettier (#629) --------- Co-authored-by: Ayman <[email protected]> Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: nicoshark <[email protected]> Co-authored-by: Nesopie <[email protected]> * fix: vc_and_disclose_id test (#640) * fix: vc_and_disclose_id test * chore: yarn prettier * fix: check if a config id exists * chore: change the function where the config not set verification is happening * fix: add await * feat: add getConfigId function in SelfVerificationRoot (#650) * feat: add getConfigId function in SelfVerificationRoot * update comment --------- Co-authored-by: motemotech <[email protected]> * chore: fix ofac end index in eu id cards * chore: fix tests * fix: example contracts and tests --------- Co-authored-by: turnoffthiscomputer <[email protected]> Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: nicoshark <[email protected]> * Update deployment module for Identity Verification Hub V2 with detailed documentation and library linkage for CustomVerifier. Update initialization process to reflect changes in V2 implementation, ensuring proper setup for proxy deployment. (#658) * publish npm-package (#651) * App/eu id updates (#638) * fix build issues * generate disclosure proof with euids * generate disclosure proof with euids * Eu id updates 2 (#648) * update vc_and_disclose_id test (dev branch) (#641) * fix: vc_and_disclose_id test * chore: yarn prettier * Show modal on NFC scan error (#642) * Add help button and error modal actions * fix the screen management * yarn nice * Bump build v2.5.4: ios 132; android 71 (#631) * bump version and build numbers * remove tamagui/toast * fix marketing version * fix: update TD1 and TD3 checks (#643) * bum yarn.lock * add version and user defined data --------- Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> * remove the mock user define data * get the useridentifier as a hash from the user defined data * chore: add version and userDefinedData * feat: use the version in register / dsc proofs as well * update calculateUserIdentifierHash * yarn nice * refactor: consolidate user context data handling and update payload structure * fix typing issues on sha1 * remove console.log(sha1) * fix sha1 import * refactor: streamline userDefinedData handling and adjust payload type for circuit * refactor: update sha1 usage and enhance logging in calculateUserIdentifierHash * yarn nice * yarn lint common * use ts-ignore for sha1 import * fix app ci tests * fix typing issue * remove unused ts-ignore * cast uuid before calling generateinputs * bump qrcode version * add tsup on the qrcode sdk * fix: exports on selfxyz/qrcode * update how we define config.version * fix yarn imports * yarn format --------- Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: Ayman <[email protected]> * Hotfix contract compile error (#660) * Fix previous rebase error * Refactor deployment module for Identity Verification Hub V2. * Fix/sdk (#652) * fix: sdk build configs * chore: SelfBackendVerifier (WIP) * feat: add custom verification * feat: consider destination chain in user defined data * chore: export attestation id * chore: export attestation id * chore: export config storage * chore: don't throw an error if the proof is not valid * chore: trim abi and rm typechain types * refactor * chore: rm unnecessary exports * 📝 Add docstrings to `fix/sdk` (#653) Docstrings generation was requested by @remicolin. * https://github.com/selfxyz/self/pull/652#issuecomment-2992046545 The following files were modified: * `sdk/core/src/utils/hash.ts` * `sdk/core/src/utils/proof.ts` * `sdk/core/src/utils/utils.ts` Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * review fixes * chore: fix package.json cjs types * chore: add minor changes to checks * feat: add InMemoryConfigStore, allIds constant and verificationResult type * chore: export Verification config * feat: change the verification config types * fix: throw issues early if verification config is null * fix: update yarn.lock file * chore: lint * fix: rm ts expect error directive * fix: contract tests * use excluded countries instead forbidden countries list * chore: change types in constnats --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update npm-publish workflow and bump core package version to 1.0.0 (#661) * update import * Update get verification config visibility (#664) * Update deployment module for Identity Verification Hub V2 to correct file paths and module name for deployment commands. * Add troubleshooting documentation for verification issues in deployHubV2.ts. Include manual verification steps and common failure reasons to assist users during deployment. * Change visibility of getVerificationConfigV2 function from internal to public in IdentityVerificationHubImplV2 contract to allow external access. * Apply BUSL v1.1 license headers to app (#665) * Add BSL license headers to app sources * prettier * fix license reference - https://spdx.org/licenses/BUSL-1.1.html * bump build: android 73 (#659) * Contracts/deploy staging (#668) * update scripts * deploy vc and disclose id * fix the deployment scripts on staging * update yarn.lock * bump ios build and version (#669) * configure coderabbitai (#670) * tweak coderabbit * bump * more thorough test spec * Apply BSL to app codebase (#639) * Clean up root license wording * Simplify SPDX header * simplify license and rename BSL to BUSL * fix merge issues * fix missing method --------- Co-authored-by: Justin Hernandez <[email protected]> * SEL-423 apply xcode build suggestions (#671) * apply recommended app settings from xcode * stick to portrait orientation and update target settings * remove app clip references * Circuit audit fixes (#644) * feat: add range checks before use of LessEqThan and SelectSubArray * fix: Num2Bits_strict to constrain virtualKey * bump core version * bump core version and fix ci * chore: use npm_auth_token in yarnrc * chroe: rm yarnrc changes * chore: update npm publish * chore: run npm publish manually * chore: change hub contract address (#675) * Update npm-publish.yml * chore: use proper secret when publishing * feat: enable publishing if workflow was triggered manually * Contracts/update verifier (#673) * update hardhat config * update vc and disclose verifier * update vc and disclose verifier script and run it * update test self verification root * update verifier * bump sdk version and use new hub address * chore: update zk-kit binary merkle root dep (#674) * refactor deployment scripts (#678) * feat: add register eu id instances (#682) * feat: add register eu id instances * feat: add new instances * chore: update scripts * chore: fix sig alg * chore: rm circuits --------- Co-authored-by: Ayman <[email protected]> Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: nicoshark <[email protected]> Co-authored-by: Nesopie <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Kevin Lin <[email protected]> Co-authored-by: kevinsslin <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Eric Nakagawa <[email protected]> * fix: commitment hash * fix: register aadhaar test * chore: refactor * feat: reveal data in packed bytes * feat: add constrain on delimiterIndices * feat: reveal timestamp * merge main to feat/aadhaar * fix: tests * feat: hash pubKey * feat: add registry contract * feat: Update HubImplV2 (WIP) * add functions to generate aadhaar data (WIP) * modularize aadhaar data generation (WIP) * fix(wip): register test * fix: test qr extractor * fix * chore: refactor functions * feat: add age extractor and tested * feat: add isMiniumAge check * fix: prepareAadhaarTestData func * registry contract tests * feat: registry contract tests * feat: extract fields from qr data bytes * chore: refactor mockData * feat: move minimum age to revealPackedData * feat: create a constant.ts to retrive fields from unpacked bytes * chore: refactor * fix: exports * rebase * rebase * feat: add public signal ,indices mapping * chore: add public output to indices mapping * fix:AADHAAR_PUBLIC_SIGNAL_INDICES * feat: make nullifier public * fix: nullifier cal for disclose circuits * feat: merge isMiniumAgeValid and miniumAge signal * fix: disclsoe test * feat: support for user identifier and secret * chore :refactor * feat: ofac test last name , firstname * feat: add forbidden_countries_list check * feat: add tests for aadhaar (WIP) * failing ofac tests * feat: finish contract tests * fix: merge conflicts * update the common package to be usable in circuits and contracts * lint everything * coderabbit fixes * chore: update name dob,yob aadhaar ofac tree * feat: merge ofac and reverse ofac check into one * test: merged ofac constrain * SELF-253 feat: add user email feedback (#889) * feat: add sentry feedback * add sentry feedback to web * feat: add custom feedback modal & fix freeze on IOS * yarn nice * update lock * feat: show feedback widget on NFC scan issues (#948) * feat: show feedback widget on NFC scan issues * fix ref * clean up * fix report issue screen * abstract send user feedback email logic * fixes * change text to Report Issue * sanitize email and track event messge * remove unnecessary sanitization * add sanitize error message tests * fix tests * save wip. almost done * fix screen test * fix screen test * remove non working test --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> * chore: centralize license header checks (#952) * chore: centralize license header scripts * chore: run license header checks from root * add header to other files * add header to bundle * add migration script and update check license headers * convert license to mobile sdk * migrate license headers * remove headers from common; convert remaining * fix headers * add license header checks * update unsupported passport screen (#953) * update unsupported passport screen * yarn nice * feat: support new ofac trees * fix: qr extractor tests * chore: remove unassigned age signal * chore: modify timestamp func comment * fix: add constrain on photo bytes delimiter * fix: add range check on minimumAge within 2^7 * fix: range check for country not in list * chore: remove dummy constrain * fix: assert lessthan * fix: check is photoEOI valid * fix: replace maxDataLength with qrPaddedLength for valid del indices * feat: update forbidden countries in disclose and disclose id * feat: convert name to uppercase * fix: add constrain between delimiter and photoEOI * feat: support for phno len 4 and 10 * chore: hard-code attestaion_ID to 3 * feat: calculate nullifier using uppercase name * feat: add real id support * fix: rebase error * chore: refactor * add new nullifier and commitment calc * fix: reuse uppercase name from verify commitment * feat: add a function that will iterate though all pubkeys * chore: skip real id test * chore: yarn format * chore: update yarn.lock * chore: rm trailing / from import * chore: add support for issuing state * chore: linting and types * chore: rm types script from circuits * chore: add license header --------- Co-authored-by: nicoshark <[email protected]> Co-authored-by: turnoffthiscomputer <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: turboblitz <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: crStiv <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: James Niken <[email protected]> Co-authored-by: Kevin Lin <[email protected]> Co-authored-by: leopardracer <[email protected]> Co-authored-by: Olof Andersson <[email protected]> Co-authored-by: vishal <[email protected]> Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: kevinsslin <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Eric Nakagawa <[email protected]> * fix: CLA not supported (#1027) * fix: CLA not supported * fix "yarn android" building * remove unnecessary commands --------- Co-authored-by: Justin Hernandez <[email protected]> * chore: bump app version v2.6.5 (#1034) * update gem lock * bump build and version * fix app versions * chore: fix nfc passport reader private repo access (#1042) * add internal repo pat * update nfc passport reader location * update workflows to use PAT to access NFC Passport Reader * fix ci * update logic to access private repo * build(android): support 16KB page size (#1043) * build(android): support 16KB page size * fix 16kb * update lock * chore: bump v2.6.5 for release (#1036) * bump build * update to ssh clone to fix local build * update podfile lock * fix version * Feat/build aadhaar (#1044) * feat: build aadhaar circuits as well in the ci * feat: add register aadhaar case handling * fix aadhaar register output after building the cpp circuit (#1045) * fix: metro js crypto module build issues (#1047) * fix sdk build issues * fix build error * sort and fix dependencies * add constants-browserify * feat: add new verifiers (#1049) * feat: add new verifiers * format: contracts * fix: ofac check to aadhaar (#1050) * fix: hub-v2 (#1051) * Add DisclosureVerified event for comprehensive verification tracking (#945) * Add VerificationPerformed event to track verification calls - Added VerificationPerformed event with comprehensive tracking fields - Captures requestor contract, version, attestation ID, chain ID, config ID, user identifier, output, and user data - Enhanced _executeVerificationFlow to return additional tracking data - Event emission placed after verification completion for accurate tracking * chore: run formatter * chore: rename verify event name to DisclosureVerified * move clearPassportData, markCurrentDocumentAsRegistered, reStorePassportDataWithRightCSCA to SDK (#1041) * Move self app store to mobile sdk (#1040) * chore(mobile-sdk-alpha): remove unused tslib dependency (#1053) * remove tslib -- seems unused * remove deps accidentally added to root * build file * remove unused imports (#1055) * fix: sha256 signed attr tests (#1058) * fix mock screen launch (#1059) * Hotfix: Belgium ID cards (#1061) * feat: parse belgium TD1 mrz android * feat: Parse Belgium TD1 MRZ IOS * fix: OFAC trees not found (#1060) * fix: relax OFAC tree response validation * test: cover OFAC tree edge cases * fix stateless * revert and fix types * fix tests * [SELF-723] feat: add structured NFC and Proof logging (#1048) * feat: add structured NFC logging * fix ci * Fix: add deps * logging fixes. use breadcrumbs * fix android build * update SeverityLevel * [SELF-705] feat: add proof event logging (#1057) * feat: add proof event logging * refactor: unify sentry event logging * fix types * fix mock * simplify * code rabbit feedback * fix tests --------- Co-authored-by: seshanthS <[email protected]> * skip on dev (#1063) * don't get fancy just disable (#1064) * saw it building so gonna try (#1065) * Dev (#1074) * chore: bump v2.6.5 rd2 (#1067) * commit wip version bump * remove from building * chore: update tooling dependencies (#1069) * chore: update tooling dependencies * chore: align react typings and node types * update lock * chore: minor fixes across monorepo (#1068) * small fixes * fixes * fix gesture handler error * ci fixes * fix yarn build; add workflow ci (#1075) * add new workspace ci * disable package version check for now * build before checks * format * fix in future pr * feat: add functions for disclosing aadhaar attributes (#1033) * feat: add functions for disclosing aadhaar attributes * format * chore: update monorepo artifacts (#1079) * remove unneeded artifacts, skip building circuits * update md files * cleans up unused parts of sdk interface, adds inline documentation, (#1078) * cleans up unused parts of sdk interface, adds inline documentation, * fix up build * yolo * Feat/aadhaar sdk (#1082) * feat: add aadhaar support to the ts sdk * feat: aadhaar support to go sdk * chore: refactor * move clearPassportData, markCurrentDocumentAsRegistered, reStorePassportDataWithRightCSCA to SDK (#1041) * Move self app store to mobile sdk (#1040) * chore(mobile-sdk-alpha): remove unused tslib dependency (#1053) * remove tslib -- seems unused * remove deps accidentally added to root * build file * remove unused imports (#1055) * fix: sha256 signed attr tests (#1058) * fix mock screen launch (#1059) * Hotfix: Belgium ID cards (#1061) * feat: parse belgium TD1 mrz android * feat: Parse Belgium TD1 MRZ IOS * fix: OFAC trees not found (#1060) * fix: relax OFAC tree response validation * test: cover OFAC tree edge cases * fix stateless * revert and fix types * fix tests * [SELF-723] feat: add structured NFC and Proof logging (#1048) * feat: add structured NFC logging * fix ci * Fix: add deps * logging fixes. use breadcrumbs * fix android build * update SeverityLevel * [SELF-705] feat: add proof event logging (#1057) * feat: add proof event logging * refactor: unify sentry event logging * fix types * fix mock * simplify * code rabbit feedback * fix tests --------- Co-authored-by: seshanthS <[email protected]> * skip on dev (#1063) * don't get fancy just disable (#1064) * saw it building so gonna try (#1065) * chore: bump v2.6.5 rd2 (#1067) * commit wip version bump * remove from building * chore: update tooling dependencies (#1069) * chore: update tooling dependencies * chore: align react typings and node types * update lock * chore: minor fixes across monorepo (#1068) * small fixes * fixes * fix gesture handler error * ci fixes * fix yarn build; add workflow ci (#1075) * add new workspace ci * disable package version check for now * build before checks * format * fix in future pr * feat: add functions for disclosing aadhaar attributes (#1033) * feat: add functions for disclosing aadhaar attributes * format * chore: update monorepo artifacts (#1079) * remove unneeded artifacts, skip building circuits * update md files * chore: update hub contract address * format * fix: add aadhaar in AllIds * chore: bump to v1.1.0-beta --------- Co-authored-by: vishal <[email protected]> Co-authored-by: Leszek Stachowski <[email protected]> Co-authored-by: Aaron DeRuvo <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: seshanthS <[email protected]> * feat: change to gcp attestation verification (#959) * feat: change to gcp attestation verification * lint * fix e2e test * chore: don't check PCR0 mapping if building the app locally * fmt:fix --------- Co-authored-by: Justin Hernandez <[email protected]> * Mobile SDK: move provingMachine from the app (#1052) * Mobile SDK: move provingMachine from the app * lint, fixes * fix web build? * lint * fix metro build, add deps * update lock files * move the status handlers and proving machine tests * may it be * fix up * yolo --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Aaron DeRuvo <[email protected]> * Revert "Mobile SDK: move provingMachine from the app (#1052)" (#1084) This reverts commit 8983ac22688f731bca8890cbf9be9c85b4ac2bf…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mobile Testing
Summary
This PR completes the React Native upgrade to 0.76.9, including all necessary toolchain and configuration updates.
Testing
yarn workspaces foreach -p -v --topological-dev --since=HEAD run nice --if-present(no output)yarn lint(fails: Unable to resolve module@selfxyz/common/utils/proving)yarn build(fails: process exited with code 129)yarn workspace @selfxyz/contracts build(fails: Hardhat config error)yarn types(fails: process exited with code 129)yarn test(fails: missing node_modules state file)https://chatgpt.com/codex/tasks/task_b_68a9215e2758832d9d98428226a08c9a
Summary by CodeRabbit
Platform Support
Improvements
CI / Tooling
UX Changes
Chores