Skip to content

Bump version to 2.5.1 #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2025
Merged

Bump version to 2.5.1 #522

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b6f86b6
bump version
transphorm Apr 17, 2025
291cbb0
update fastlane
transphorm Apr 17, 2025
2903a4f
fix bump version
transphorm Apr 17, 2025
2e05797
bump build and add todo
transphorm Apr 17, 2025
735f9d8
disable commit for now
transphorm Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions app/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,18 @@ GEM
artifactory (3.0.17)
atomos (0.1.3)
aws-eventstream (1.3.2)
aws-partitions (1.1069.0)
aws-sdk-core (3.220.1)
aws-partitions (1.1088.0)
aws-sdk-core (3.222.2)
aws-eventstream (~> 1, >= 1.3.0)
aws-partitions (~> 1, >= 1.992.0)
aws-sigv4 (~> 1.9)
base64
jmespath (~> 1, >= 1.6.1)
logger
aws-sdk-kms (1.99.0)
aws-sdk-core (~> 3, >= 3.216.0)
aws-sigv4 (~> 1.5)
aws-sdk-s3 (1.182.0)
aws-sdk-s3 (1.183.0)
aws-sdk-core (~> 3, >= 3.216.0)
aws-sdk-kms (~> 1)
aws-sigv4 (~> 1.5)
Expand Down Expand Up @@ -129,7 +130,7 @@ GEM
faraday_middleware (1.2.1)
faraday (~> 1.0)
fastimage (2.4.0)
fastlane (2.227.0)
fastlane (2.227.1)
Copy link
Member Author

@transphorm transphorm Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upgrade fastlane

CFPropertyList (>= 2.3, < 4.0.0)
addressable (>= 2.8, < 3.0.0)
artifactory (~> 3.0)
Expand Down Expand Up @@ -169,7 +170,7 @@ GEM
tty-spinner (>= 0.8.0, < 1.0.0)
word_wrap (~> 1.0.0)
xcodeproj (>= 1.13.0, < 2.0.0)
xcpretty (~> 0.4.0)
xcpretty (~> 0.4.1)
xcpretty-travis-formatter (>= 0.0.3, < 2.0.0)
fastlane-plugin-increment_version_code (0.4.3)
fastlane-plugin-versioning_android (0.1.1)
Expand Down Expand Up @@ -292,7 +293,7 @@ GEM
colored2 (~> 3.1)
nanaimo (~> 0.4.0)
rexml (>= 3.3.6, < 4.0)
xcpretty (0.4.0)
xcpretty (0.4.1)
rouge (~> 3.28.0)
xcpretty-travis-formatter (1.0.1)
xcpretty (~> 0.2, >= 0.0.7)
Expand Down
6 changes: 3 additions & 3 deletions app/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ android {
applicationId "com.proofofpassportapp"
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 53
versionName "2.5.0"
versionCode 54
versionName "2.5.1"
externalNativeBuild {
cmake {
cppFlags += "-fexceptions -frtti -std=c++11"
Expand Down Expand Up @@ -162,4 +162,4 @@ dependencies {
implementation "androidx.profileinstaller:profileinstaller:1.3.1"

implementation "com.google.android.play:app-update:2.1.0"
}
}
3 changes: 2 additions & 1 deletion app/fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ platform :ios do
upload_to_testflight(
api_key: result[:api_key],
distribute_external: true,
# TODO: fix error about the groups not being set correctly, fwiw groups are set in the app store connect
Copy link
Member Author

@transphorm transphorm Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using yarn force-local-upload-test:ios worked. but it threw an error about the groups

Screenshot 2025-04-17 at 10 46 51 AM

groups: ENV["IOS_TESTFLIGHT_GROUPS"].split(","),
changelog: "",
skip_waiting_for_build_processing: false,
Expand Down Expand Up @@ -207,7 +208,7 @@ platform :android do
lane :sync_version do
android_set_version_name(
version_name: package_version,
gradle_file: android_gradle_file_path,
gradle_file: android_gradle_file_path.gsub("../", ""),
Copy link
Member Author

@transphorm transphorm Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix gradle path error whe syncing app version

)
end

Expand Down
2 changes: 1 addition & 1 deletion app/ios/OpenPassport/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>$(MARKETING_VERSION)</string>
<string>2.5.1</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
Expand Down
2 changes: 1 addition & 1 deletion app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "openpassport",
"version": "2.4.9",
"version": "2.5.1",
"private": true,
"scripts": {
"analyze:android": "yarn reinstall && react-native-bundle-visualizer --platform android --dev",
Expand Down
Loading