fix: go-sdk

[Vishalkulkarni45]

Summary by CodeRabbit

• Bug Fixes
  • Standardized age verification across attestations, improving accuracy for non-Aadhaar proofs and ensuring consistent results across document types.
  • Updated timestamp validation to honor an end-of-day window, reducing unintended expiry failures and aligning behavior with other platforms.
  • Improves overall reliability of verification outcomes without requiring any user action.
• Chores
  • No changes to public APIs; compatibility maintained.

[coderabbitai]

Walkthrough

The Go SDK updates align minimumAge parsing for non-Aadhaar with the Aadhaar path by using a string slice instead of a single-byte conversion. Timestamp validation now treats circuit timestamps as valid through end-of-day by comparing against a computed end-of-day value.

Changes

Cohort / File(s)	Summary
Minimum age parsing alignment sdk/sdk-go/utils.go	Non-Aadhaar minimumAge extraction now uses the full string slice [OlderThanStart:OlderThanEnd+1], matching Aadhaar handling; removes prior single-byte numeric formatting path.
Timestamp EOD validation sdk/sdk-go/verifier.go	validateTimestamp adds end-of-day computation (circuitTimestampEOD = circuitTimestamp + 23h59m59s) and compares EOD to oneDayAgo; adds comments for parity with TypeScript logic.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Caller
  participant Utils as FormatRevealedDataPacked
  participant Data as RevealedData

  Caller->>Utils: FormatRevealedDataPacked(Data)
  Utils->>Data: Read OlderThanStart, OlderThanEnd, isAadhaar
  alt Aadhaar or Non-Aadhaar (new path)
    Utils->>Utils: minAge = string slice [start:end+1]
  end
  Utils-->>Caller: Packed output with minAge
  note right of Utils: Non-Aadhaar no longer uses single-byte decimal

Loading

sequenceDiagram
  autonumber
  participant Verifier as validateTimestamp
  participant Input as circuitTimestamp
  participant Clock as Now()

  Verifier->>Clock: Get current time
  Clock-->>Verifier: now
  Verifier->>Verifier: oneDayAgo = now - 24h
  Verifier->>Verifier: circuitTimestampEOD = circuitTimestamp + 23:59:59
  alt Old check (previous)
    note over Verifier: circuitTimestamp.Before(oneDayAgo)
  else New check (current)
    Verifier->>Verifier: isOld = circuitTimestampEOD.Before(oneDayAgo)
  end
  Verifier-->>Caller: Validation result
  note right of Verifier: Aligns with TS end-of-day semantics

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

Strings, not bytes, now tell the age,
The clock extends the day’s last page.
Go whispers, “Wait till midnight’s done,”
Before it calls a timestamp shunned.
Two tweaks align the paths and time—
A tidier beat, a truer chime. ⏳✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "fix: go-sdk" is directly related to the changes since the diff modifies the Go SDK, but it is overly generic and does not describe the specific fixes (minimumAge parsing alignment and end-of-day timestamp handling). Because it references the affected component it satisfies the "partially related" criterion and the check passes.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/go-sdk

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 86c595b and d517ee8.

📒 Files selected for processing (2)

• sdk/sdk-go/utils.go (1 hunks)
• sdk/sdk-go/verifier.go (1 hunks)

🔇 Additional comments (1)

sdk/sdk-go/verifier.go (1)

632-637: End-of-day tolerance: confirm spec parity and future-side semantics.

EOD padding for the “too old” check looks correct and matches the intent. The “future” check still uses strict now+24h, which is asymmetric with the EOD leniency. If the TypeScript SDK considers “tomorrow’s date” valid through end-of-day as well, mirror that here; otherwise please confirm this intentional asymmetry.

[coderabbitai]

⚠️ Potential issue

MinimumAge raw slice may include NULs/non‑digits; normalize to digits to avoid mis-parse in validation.

Switching non‑Aadhaar to a raw byte slice can surface padding bytes (0x00) or non‑digit characters, causing fmt.Sscanf() in validateWithConfig to parse partially or fail, leading to incorrect allow/deny. Normalize to a two‑digit numeric string before returning.

Apply:

- } else {
-   minimumAge = string(revealedDataPackedBytes[revealedDataIndices.OlderThanStart : revealedDataIndices.OlderThanEnd+1])
- }
+ } else {
+   // Normalize to two-digit numeric string; strip non-digits/NULs
+   raw := revealedDataPackedBytes[revealedDataIndices.OlderThanStart : revealedDataIndices.OlderThanEnd+1]
+   buf := make([]byte, 0, 2)
+   for _, b := range raw {
+     if b >= '0' && b <= '9' {
+       buf = append(buf, b)
+     }
+   }
+   switch len(buf) {
+   case 0:
+     minimumAge = "00"
+   case 1:
+     minimumAge = "0" + string(buf)
+   default:
+     minimumAge = string(buf[:2])
+   }
+ }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	} else {
	minimumAge = string(revealedDataPackedBytes[revealedDataIndices.OlderThanStart : revealedDataIndices.OlderThanEnd+1])
	}
	} else {
	// Normalize to two-digit numeric string; strip non-digits/NULs
	raw := revealedDataPackedBytes[revealedDataIndices.OlderThanStart : revealedDataIndices.OlderThanEnd+1]
	buf := make([]byte, 0, 2)
	for _, b := range raw {
	if b >= '0' && b <= '9' {
	buf = append(buf, b)
	}
	}
	switch len(buf) {
	case 0:
	minimumAge = "00"
	case 1:
	minimumAge = "0" + string(buf)
	default:
	minimumAge = string(buf[:2])
	}
	}

🤖 Prompt for AI Agents

In sdk/sdk-go/utils.go around lines 462 to 464, the code assigns minimumAge
directly from a raw byte slice which may include NULs or non-digit bytes;
instead, extract only digit characters from
revealedDataPackedBytes[revealedDataIndices.OlderThanStart:revealedDataIndices.OlderThanEnd+1],
build a normalized two‑digit string (if no digits -> "00", if one digit ->
prepend '0', if multiple -> use the last two digits), and assign that sanitized
string to minimumAge so downstream fmt.Sscanf() receives a clean two‑digit
numeric value.