Skip to content

Several fix for consolidation #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 5, 2022
Merged

Several fix for consolidation #1880

merged 10 commits into from
Oct 5, 2022

Conversation

@fabienwnklr
Copy link
Contributor

@fabienwnklr fabienwnklr commented Oct 4, 2022

  • Fix : calcul height if 'optgroup' present : calcul of numberItems is wrong if optgroup present (bad selector..)
  • Style: dropdrow_header if dropdownParent = 'body' : if we use dropdrow_header plugin with dropdownParent = 'body' whe lose the style
  • Fix: close dropdown with dropdown_header plugin : click on close button do nothing, now it close the dropdown

@risadams risadams merged commit 8c59f13 into selectize:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@risadams risadams risadams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fabienwnklr @risadams