Skip to content

Harden directory storage#421

Merged
bsneed merged 2 commits into
mainfrom
bsneed/batch_fix
Mar 6, 2026
Merged

Harden directory storage#421
bsneed merged 2 commits into
mainfrom
bsneed/batch_fix

Conversation

@bsneed

@bsneed bsneed commented Mar 5, 2026

Copy link
Copy Markdown
Contributor
  • Add file validation before handing off to uploader.
  • Check if files are finalized before appending to them.

@codecov

codecov Bot commented Mar 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.18%. Comparing base (6e9ec95) to head (f809dfc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   70.42%   71.18%   +0.75%     
==========================================
  Files          49       49              
  Lines        3686     3699      +13     
==========================================
+ Hits         2596     2633      +37     
+ Misses       1090     1066      -24     
Files with missing lines Coverage Δ
...gment/Utilities/Storage/Types/DirectoryStore.swift 85.36% <100.00%> (+1.72%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lalmalani lalmalani left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Addresses 1 optimization to prevent a hard-to-repro race condition.
We check for file completion via a newly introduced function (BOOL) isFInished (which checks to see if there is a "sentAt" string match in the last line of file.
If isFinished returns true, we check again and start a new file with an incremented filename

@bsneed bsneed merged commit e9652b4 into main Mar 6, 2026
21 checks passed
@bsneed bsneed deleted the bsneed/batch_fix branch March 6, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants