Harden directory storage#421
Merged
Merged
Conversation
bsneed
commented
Mar 5, 2026
Contributor
- Add file validation before handing off to uploader.
- Check if files are finalized before appending to them.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
+ Coverage 70.42% 71.18% +0.75%
==========================================
Files 49 49
Lines 3686 3699 +13
==========================================
+ Hits 2596 2633 +37
+ Misses 1090 1066 -24
🚀 New features to boost your workflow:
|
lalmalani
approved these changes
Mar 6, 2026
lalmalani
left a comment
There was a problem hiding this comment.
PR Addresses 1 optimization to prevent a hard-to-repro race condition.
We check for file completion via a newly introduced function (BOOL) isFInished (which checks to see if there is a "sentAt" string match in the last line of file.
If isFinished returns true, we check again and start a new file with an incremented filename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.