This repository was archived by the owner on Feb 13, 2024. It is now read-only.
Fix for infinite axios-retry on 5xx responses and axios client option leakage#255
Merged
pooyaj merged 4 commits intosegmentio:masterfrom Oct 26, 2020
Merged
Fix for infinite axios-retry on 5xx responses and axios client option leakage#255pooyaj merged 4 commits intosegmentio:masterfrom
pooyaj merged 4 commits intosegmentio:masterfrom
Conversation
Contributor
Author
Contributor
Author
|
Hi @ivolo @travisjeffery @f2prateek - I noticed that the three of you appear to be the top committers to this repository and I was interested in getting your thoughts on this particular pull request. I believe this PR will resolve a few outstanding issues and I'd love to help with a potential fix. Is there anything additional that you'd like to see in this PR for it to receive approval? |
Contributor
pooyaj
approved these changes
Oct 26, 2020
Contributor
pooyaj
left a comment
pooyaj
left a comment
There was a problem hiding this comment.
Thanks for sending the PR! Looks great ✨
Contributor
|
@yujidude I published |
Contributor
Author
|
Fantastic! Thank you again for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge seeks to address two issues:
To address the first concern I've updated the current version of axios to 0.19.2 which contains the necessary fixes for avoiding infinite retries within axios when the HTTP response is within the 5xx range.
As per the second concern, I've configured the Analytics class to instead use it's own axios client, thereby preventing client options from leaking into other axios instances.
Unit tests have been added to validate that the retries are in fact working and that option leakage is no longer occuring.