Skip to content

Use SSH scheme in repository URLs #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
72636c merged 1 commit into from
Aug 29, 2022
Merged

Use SSH scheme in repository URLs #955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/gentle-rules-provide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'skuba': patch
---

template/\*-npm-package: Use SSH scheme in repository URL

We have changed the `package.json#repository/url` format from `git+https://github.com/org/repo.git` to `git+ssh://git@github.com/org/repo.git`. This may resolve `skuba release` errors that reference [Git password authentication is shutting down](https://github.blog/changelog/2021-08-12-git-password-authentication-is-shutting-down/) on the GitHub Blog.
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@
},
"repository": {
"type": "git",
"url": "git+https://github.com/seek-oss/skuba.git"
"url": "git+ssh://git@github.com/seek-oss/skuba.git"
},
"resolutions": {
"**/@types/node": ">=14.18"
Expand Down
4 changes: 2 additions & 2 deletions src/utils/copy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ describe('createEjsRenderer', () => {
const input = {
name: '<%- packageName %>',
repository: {
url: 'git+https://github.com/<%- orgName %>/<%- repoName %>.git',
url: 'git+ssh://git@github.com/<%- orgName %>/<%- repoName %>.git',
},
};

Expand All @@ -22,7 +22,7 @@ describe('createEjsRenderer', () => {
expect(JSON.parse(output)).toEqual({
name: 'seek-koala',
repository: {
url: 'git+https://github.com/seek-oss/koala.git',
url: 'git+ssh://git@github.com/seek-oss/koala.git',
},
});
});
Expand Down
2 changes: 1 addition & 1 deletion template/oss-npm-package/_package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"name": "<%- moduleName %>",
"repository": {
"type": "git",
"url": "git+https://github.com/<%- orgName %>/<%- repoName %>.git"
"url": "git+ssh://git@github.com/<%- orgName %>/<%- repoName %>.git"
},
"scripts": {
"build": "skuba build-package",
Expand Down
2 changes: 1 addition & 1 deletion template/private-npm-package/_package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"name": "<%- moduleName %>",
"repository": {
"type": "git",
"url": "git+https://github.com/<%- orgName %>/<%- repoName %>.git"
"url": "git+ssh://git@github.com/<%- orgName %>/<%- repoName %>.git"
},
"scripts": {
"build": "skuba build-package",
Expand Down