aws cli v2 support #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72636c
reviewed
Feb 21, 2022
hooks/lib/ecr-registry-provider.bash
Outdated
| local aws_cli_version=$(aws --version 2>&1 | cut -d " " -f1 | cut -d "/" -f2) | ||
|
|
||
| if [[ $aws_cli_version =~ ^1 ]]; then | ||
| $(aws ecr get-login --no-include-email) |
Member
There was a problem hiding this comment.
AWS CLI V1 also supports get-login-password and has get-login marked as deprecated.
I'd be keen for us to drop this entirely; we can do a major version increment if need be. I'm not sure which V1 version added get-login-password but I think it's been around for years at this point.
Contributor
Author
There was a problem hiding this comment.
Ah, that simplifies it a lot in that case. Will push an update shortly
…tion from plugin config
renkoh
commented
Feb 21, 2022
| } | ||
|
|
||
| get_ecr_region() { | ||
| echo "${BUILDKITE_PLUGIN_DOCKER_ECR_CACHE_REGION:-${AWS_DEFAULT_REGION:-eu-west-1}}" |
Contributor
Author
There was a problem hiding this comment.
we've used eu-west-1 for consistency across the ECR plugins
lantrix
approved these changes
Feb 21, 2022
Co-authored-by: Ryan Ling <[email protected]>
relientm96
approved these changes
Feb 21, 2022
72636c
reviewed
Feb 22, 2022
| - docker#v3.8.0 | ||
| ``` | ||
|
|
||
| #### Specifying a region |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for aws-cli v2, which is installed by default on newer versions of Elastic CI.
Maintains backwards compatibility with aws-cli v1.17.10 (released in Febuary 2020) or later