Skip to content

remove G113. It only affects old/unsupported versions of Go #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 3, 2025
Merged

remove G113. It only affects old/unsupported versions of Go #1328

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2e5f9b0
don't warn on G113 (big.Rat SetString) if on an unaffected version of Go
niij Apr 1, 2025
d240b39
alert on all known versions
niij Apr 1, 2025
16f385d
remove G113 CVE-2022-23772 which only affects old/unsupport Go versions
niij Apr 2, 2025
c498080
Retire rule
niij Apr 3, 2025
beefbee
gofmt
niij Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions rules/math_big_rat.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,12 @@ func (r *usingOldMathBig) Match(node ast.Node, ctx *gosec.Context) (gi *issue.Is
return nil, nil
}

confidence := issue.Low
major, minor, build := gosec.GoVersion()
if major == 1 && (minor == 16 && build < 14 || minor == 17 && build < 7) {
confidence = issue.Medium
return ctx.NewIssue(node, r.ID(), r.What, r.Severity, issue.Medium), nil
} else {
return nil, nil
}

return ctx.NewIssue(node, r.ID(), r.What, r.Severity, confidence), nil
}

// NewUsingOldMathBig rule detects the use of Rat.SetString from math/big.
Expand Down