Create a vcpkg issue to package mathplot

[sebsjames]

This depends on sebsjames/maths being packaged: sebsjames/maths#8

[sebsjames]

@miyanyan are you able to help with this?

[miyanyan]

I can try it, then remove the maths submodule and add to vcpkg.json?

[miyanyan]

btw, the name maths is too common and maybe need aliased.

[sebsjames]

Hi Miyan, I'll have a think about that over the next week (I'm on holiday) and come back to you.

[sebsjames]

So, I took a look at nlohmann json, whose repository is just called 'json'. The vcpkg for this repo is called 'nlohmann-json'; presumably this is an alias? sebsjames-maths seems good to me as an alias.

[sebsjames]

Great, sebsjames/maths is now packaged in vcpkg!

[miyanyan]

May I remove the maths submodule and add to vcpkg.json? the submodule is not friendly to me, it's too slow to download the submodule 😭

[sebsjames]

Hi Miyan, I am hesitant to remove the submodule. I'm interested in what way it is slow? To download?

I think we could keep the submodule, but make it optional. That is, you could use a vcpkged maths or the submodule.

[miyanyan]

Hi Miyan, I am hesitant to remove the submodule. I'm interested in what way it is slow? To download?

I got the reason, I didn't set the ssh key of this pc for github...

[sebsjames]

Glad you can now clone recursively.

I do still think the submodule should be optional - so that when a user installs with vcpkg they get the maths vcpkg and the mathplot vcpkg (without a submodule for maths), BUT when they're developing with a clone from github, they can just clone recursively and that gives them all the code they need.

[sebsjames]

This may be achieved by adding lines something like this in CMakeLists.txt:

set(SEBSJAMES_MATHS_INCLUDE  "${PROJECT_SOURCE_DIR}/maths" CACHE STRING
      "The path to sebsjames/maths. Defaults to the git-submoduled version within mathplot but can be any other location that contains the sm directory"
      FORCE)

[rremilian]

Hi @sebsjames, do you still need help with this ?

[sebsjames]

Hi @rremilian yes, this has stalled a little. I'm not quite sure how to deal with the fact that the maths code is now in a submodule.

[rremilian]

I will have a look tomorrow. However, considering that maths is already in vcpkg, couldn't we use it directly from there and add it as a dependency for mathplot ?