Skip to content

Minor improvements#390

Merged
adams85 merged 3 commits intomainfrom
minor-improvements
Jul 28, 2023
Merged

Minor improvements#390
adams85 merged 3 commits intomainfrom
minor-improvements

Conversation

@adams85
Copy link
Collaborator

@adams85 adams85 commented Jul 28, 2023

Some more polishing.

@adams85 adams85 requested a review from lahma July 28, 2023 21:43
Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@adams85
Copy link
Collaborator Author

adams85 commented Jul 28, 2023

Thanks for the quick review!

I had doubts about 22b6471, so did some research about exactly how .NET deals with string constants.

The pre-generated version would result in ldstr operations, which works like this under the hood. Not quite what I hoped for... So I'd rather drop this change because it'd just increase the assembly size by 3 kB without a real benefit.

@adams85 adams85 force-pushed the minor-improvements branch from 4b47b73 to 3c8fc11 Compare July 28, 2023 22:21
@adams85 adams85 merged commit 9de2af2 into main Jul 28, 2023
@adams85 adams85 deleted the minor-improvements branch July 28, 2023 22:32
@adams85
Copy link
Collaborator Author

adams85 commented Jul 28, 2023

I believe the time is ripe for a new RC (hopefully the last one before the final 3.x). If you agree, would you do the honors, please? :)

@lahma
Copy link
Collaborator

lahma commented Jul 29, 2023

3.0.0-rc-03 published! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants