Conversation
…xpression and UnaryExpression/UpdateExpression
lahma
approved these changes
Apr 10, 2023
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to improve compliance with the ESTree specification.
Besides what have been discussed here, I made an attempt to address a few further issues:
BinaryOperator/LogicalOperatorandUnaryOperator/UpdateOperatorenums as specified by the standard but have the separation w.r.t. the corresponding node types (BinaryExpression/LogicalExpressionandUnaryExpression/UpdateExpression). However, there were no checks in place to prevent instantiation of these types with a wrong operator type (e.g. aLogicalExpressionwith a multiplication operator.) Thus, checks have been added to prevent invalid combinations.bigintproperty defined by the standard can be replaced with a simpleliteral.BigIntValue.ToString()call in our current model). However, adding a subclass for the regex case seems beneficial as it's a cleaner design and reduces the memory footprint of the AST a bit. (As a matter of fact, we may also consider changingRegexValueandTemplateElementValueto readonly struct records to save a few further allocations.) I'm not sure about this change though, its impact on existing codebases might be more than acceptable. Please let me know how do you feel about this.