Fix building of release artifacts in GitHub Actions#375
Merged
Conversation
lahma
approved these changes
Feb 19, 2023
Collaborator
lahma
left a comment
lahma
left a comment
There was a problem hiding this comment.
Looks good, I had to do similar fix to Jint just yesterday. Quite the breaking change even though the consider it change for the better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like we've been bitten by this BC recently introduced in the .NET 7 SDK.
Also, we've been polluting NuGet & MyGet with our internal source generator project for a while...
This PR attempts to solve both issues.