chore(deps): Update dependencies #2652
Conversation
reneleonhardt
force-pushed
the
chore/updates
branch
from
3c7db95 to
a7e5ed5
Compare
|
Hi @reneleonhardt, thank you for submitting this PR. I suggest we split it into two: one for Rust and another for WASM. |
|
Then I remove WASM from this one first. |
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Version bump in dev-dependencies looks good to me.
|
|
||
| [target.'cfg(windows)'.dependencies] | ||
| windows-registry = "0.4" | ||
| windows-registry = "0.5" |
There was a problem hiding this comment.
windows-registry requires 1.74 which is newer than reqwest's current MSRV 1.64.
There was a problem hiding this comment.
By the way, windows-registry 0.4 requires 1.74 too but it works well so far.
I'll leave this for @seanmonstar to decide.
There was a problem hiding this comment.
cargo msrv find --min 1.70.0 never showed anything higher than 1.70.0 😅
Other dependencies already updated to 1.71 for example.
.github/dependabot.yml
Outdated
| directory: "/" | ||
| directories: | ||
| - "/" | ||
| - "/examples/wasm_github_fetch" |
There was a problem hiding this comment.
Maybe we can remove this change since they are not related.
There was a problem hiding this comment.
I'd rather not get PRs about the WASM example dependencies at all. (I occasionally get security ones for npm packages, but I wish I could turn those off. It's just an example, I don't want the commit history filled with npm updates.)
There was a problem hiding this comment.
Removed Dependabot cargo for examples/wasm_github_fetch upon request (it wasn't for npm).
reneleonhardt
force-pushed
the
chore/updates
branch
from
1578dd9 to
e10b1f2
Compare
|
I believe we've already upgraded the necessary bits in other PRs. Thanks! |
3 participants
Updates