Allow preconfigured TLS with feature = "http3"#1850
Allow preconfigured TLS with feature = "http3"#1850seanmonstar merged 1 commit intoseanmonstar:masterfrom
feature = "http3"#1850Conversation
src/async_impl/client.rs
Outdated
| #[cfg(feature = "http3")] | ||
| { | ||
| if let Some(conn) = (&mut tls as &mut dyn Any) | ||
| .downcast_mut::<Option<(rustls::ClientConfig, quinn::TransportConfig)>>() |
There was a problem hiding this comment.
I don't think I'd want to do this, because I would like to make it easier to swap in s2n-quic or similar for the QUIC implementation. Is there need to configure the TransportConfig yourself, or can we just figure it out internally?
There was a problem hiding this comment.
I don't think I'd want to do this, because I would like to make it easier to swap in s2n-quic or similar for the QUIC implementation.
How does this prevent swapping in s2n-quic?
Is there need to configure the
TransportConfigyourself, or can we just figure it out internally?
There's a bunch of configuration options that aren't exposed through ClientBuilder.
Personally I don't need it and we can definitely figure it out internally.
I will adjust the PR to generate TransportConfig instead of having to pass it through.
daxpedda
force-pushed
the
h3-preconfigured-tls
branch
from
17b943f to
258d384
Compare
|
CI currently fails because of https://github.com/bluejekyll/trust-dns/issues/1946. |
daxpedda
force-pushed
the
h3-preconfigured-tls
branch
from
258d384 to
f172314
Compare
daxpedda
force-pushed
the
h3-preconfigured-tls
branch
from
f172314 to
e226767
Compare
|
CI fails because |
daxpedda
force-pushed
the
h3-preconfigured-tls
branch
from
e226767 to
025192c
Compare
|
CI currently fails because of rust-lang/rust#113152. |
|
Wow, an instance of testing minimal-versions biting us. |
Happy to make a PR fixing it, just not sure how. I could just bump the dependency beforehand like here: reqwest/.github/workflows/ci.yml Lines 277 to 280 in 5ffaf3f See #1879. |
|
Yea that seems fine. (Or we could put it in dev-dependencies...) |
daxpedda
force-pushed
the
h3-preconfigured-tls
branch
from
025192c to
e6dea55
Compare
|
@seanmonstar friendly ping, CI passes, PR is ready to be reviewed again. |
2 participants
Currently it's impossible to use
ClientBuilder::use_preconfigured_tls()in combination with thehttp3feature:reqwest/src/async_impl/client.rs
Line 600 in 06c8e5b
This PR addresses this by requiring to pass
quinn::TransportConfigas well when using thehttp3feature.