Skip to content

Ensure that the source/readme files can only be downloaded in txt format #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2025
Merged

Ensure that the source/readme files can only be downloaded in txt format #2693

merged 2 commits into from
Oct 3, 2025

Conversation

@fealho
Copy link
Member

@fealho fealho commented Oct 2, 2025

CU-86b6xjuk7 , Resolve #2685

@sdv-team
Copy link
Contributor

sdv-team commented Oct 2, 2025

Task linked: CU-86b6xjuk7 SDV - Ensure that the source/readme files can only be downloaded in txt format #2685

@fealho fealho force-pushed the issue-2685-get-source-readme-extension branch from 28dfca4 to 9b671b3 Compare October 2, 2025 16:42
@sdv-team
Copy link
Contributor

sdv-team commented Oct 2, 2025

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@fealho fealho marked this pull request as ready for review October 2, 2025 16:59
@fealho fealho requested a review from a team as a code owner October 2, 2025 16:59
@fealho fealho requested review from amontanez24 and removed request for a team October 2, 2025 16:59
@fealho fealho requested a review from pvk-developer October 2, 2025 16:59
amontanez24
amontanez24 approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment but other than that :shipit:

@codecov
Copy link

codecov bot commented Oct 2, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.07%. Comparing base (166c317) to head (dd6133a).
⚠️ Report is 1 commits behind head on feature-branch-download-demo.

Additional details and impacted files 
@@                       Coverage Diff                        @@
##           feature-branch-download-demo    #2693      +/-   ##
================================================================
- Coverage                         98.09%   98.07%   -0.02%     
================================================================
  Files                                70       70              
  Lines                              7594     7597       +3     
================================================================
+ Hits                               7449     7451       +2     
- Misses                              145      146       +1
Flag Coverage Δ
integration 75.93% <25.00%> (-0.17%) ⬇️
unit 96.77% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pvk-developer
pvk-developer reviewed Oct 2, 2025
View reviewed changes
@fealho fealho requested a review from pvk-developer October 2, 2025 21:48
@sdv-team
Copy link
Contributor

sdv-team commented Oct 2, 2025

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@fealho fealho force-pushed the issue-2685-get-source-readme-extension branch from 6e98654 to d87f652 Compare October 2, 2025 22:51
@fealho fealho force-pushed the issue-2685-get-source-readme-extension branch from d87f652 to dd6133a Compare October 3, 2025 18:57
@sdv-team
Copy link
Contributor

sdv-team commented Oct 3, 2025

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@fealho fealho merged commit a654720 into feature-branch-download-demo Oct 3, 2025
47 checks passed
@fealho fealho deleted the issue-2685-get-source-readme-extension branch October 3, 2025 19:49
fealho added a commit that referenced this pull request Oct 6, 2025
@fealho
Ensure that the source/readme files can only be downloaded in txt for…
461036c 
…mat (#2693)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amontanez24 amontanez24 amontanez24 approved these changes

@pvk-developer pvk-developer pvk-developer approved these changes

Assignees

@fealho fealho

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fealho @sdv-team @amontanez24 @pvk-developer