Skip to content

feat(contracts): update L1GasPriceOracle for Curie fork - #1343

Merged
zimpha merged 2 commits into
developfrom
feat/new_gas_price_oracle
May 28, 2024
Merged

feat(contracts): update L1GasPriceOracle for Curie fork#1343
zimpha merged 2 commits into
developfrom
feat/new_gas_price_oracle

Conversation

@zimpha

@zimpha zimpha commented May 22, 2024

Copy link
Copy Markdown
Contributor

Purpose or design rationale of this PR

This PR update the L1GasPriceOracle for Curie fork.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@zimpha
zimpha requested a review from Thegaram May 22, 2024 12:21
@zimpha zimpha assigned icemelon and unassigned icemelon May 22, 2024
@zimpha
zimpha requested review from icemelon and spilehchiha May 22, 2024 12:22
Comment thread contracts/src/L2/predeploys/L1GasPriceOracle.sol
Comment thread contracts/src/L2/predeploys/L1GasPriceOracle.sol Outdated
Comment thread contracts/src/L2/predeploys/L1GasPriceOracle.sol
Thegaram
Thegaram previously approved these changes May 23, 2024
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.56%. Comparing base (07b8ae2) to head (3aa241e).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1343      +/-   ##
===========================================
+ Coverage    56.49%   56.56%   +0.06%     
===========================================
  Files          160      160              
  Lines        12548    12567      +19     
===========================================
+ Hits          7089     7108      +19     
  Misses        4923     4923              
  Partials       536      536              
Flag Coverage Δ
contracts 56.73% <100.00%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread contracts/src/L2/predeploys/L1GasPriceOracle.sol
Comment thread contracts/src/L2/predeploys/L1GasPriceOracle.sol
@zimpha
zimpha merged commit 7059ad0 into develop May 28, 2024
@zimpha
zimpha deleted the feat/new_gas_price_oracle branch May 28, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants