Substitute secp256k1 library for the L1 version #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, maybe also a good idea to add comments in the codes to explain why we would like to keep the ethereum's version |
|
after another look I think we should use go-ethereum v1.10.13, to be consistent with the statement in our readme |
mask-pp
reviewed
Feb 9, 2022
go.sum
Outdated
| github.com/envoyproxy/go-control-plane v0.9.1-0.20191026205805-5f8ba28d4473/go.mod h1:YTl/9mNaCwkRvm6d1a2C3ymFceY/DCBVvsKhRF0iEA4= | ||
| github.com/envoyproxy/protoc-gen-validate v0.1.0/go.mod h1:iSmxcyjqTsJpI2R4NaDN7+kN2VEUnK/pcBlmesArF7c= | ||
| github.com/ethereum/go-ethereum v1.10.15 h1:E9o0kMbD8HXhp7g6UwIwntY05WTDheCGziMhegcBsQw= | ||
| github.com/ethereum/go-ethereum v1.10.15/go.mod h1:W3yfrFyL9C1pHcwY5hmRHVDaorTiQxhYBkKyu5mEDHw= |
There was a problem hiding this comment.
We'd better stay the same version v1.10.13 !
Author
There was a problem hiding this comment.
Just changed it, should be on 1.10.13 now :)
mask-pp
approved these changes
Feb 9, 2022
0xmountaintop
added a commit
that referenced
this pull request
Apr 19, 2023
This reverts commit 59df2d7.
0xmountaintop
added a commit
that referenced
this pull request
Apr 19, 2023
pdrobnjak
pushed a commit
to Tenderly/net-scroll-geth
that referenced
this pull request
Apr 30, 2025
Co-authored-by: Yu Marvel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21