forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 284
feat(feynman): add new compression-aware rollup fee formula #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
3d50dd1
Change l1DataFee to rollupFee for Feynman
ranchalp 98f41d7
Update CommitScalarSlot to ExecScalarSlot
ranchalp 90bd9f4
Rename l1DataFee to rollupFee
ranchalp 49574cb
Scale compression ratio to match scalars precision
ranchalp 685e4ba
Use l1DataFee and commitScalar instead of rollupFee and execScalar
ranchalp b221a0c
Merge branch 'develop' into l1data-to-rollupfee
ranchalp a39317a
Merge branch 'develop' into l1data-to-rollupfee
ranchalp ce2498e
Use blocktime not blocknumber
ranchalp 2b061e4
Add unit test
ranchalp c3c5595
Clarify test comment
ranchalp 61af023
feat(feynman): upgrade gas oracle predeploy
Thegaram 080cbf3
Merge branch 'develop' into l1data-to-rollupfee
colinlyguo 93f9920
Merge branch 'feat-feynman-gas-oracle' into l1data-to-rollupfee
colinlyguo 393d6c1
address comments
b93d2c1
revert renaming CalculateL1DataFee to CalculateRollupFee
9808365
simplify EstimateL1DataFeeForMessage
3156b02
address comments
5039d30
add a comment based on pr reviews
7d7a9b6
update formula
a36f63c
tweaks
b621be4
tweak comments
872ccf5
Estimate compression ratio at rollupFee for Feynman (#1197)
ranchalp 1fbe3ea
refactoring
8df47a2
Merge branch 'develop' into l1data-to-rollupfee
Thegaram dd262c1
remove incorrect merge artifact
Thegaram bd7f658
error handling
ee255a4
update da-codec commit
bad7cac
update da-codec commit
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.