Skip to content

Conversation

@piotrek6641
Copy link
Contributor

@piotrek6641 piotrek6641 commented Aug 31, 2023

What?

  • Monitoring server package that allows checking health of a process such as STH/ manager
  • ModuleLoader to load additional modules on demand. Module should be installed manually, for example with:
    npm i @scramjet/monitoring-server -g

Usage:

  • Install @scramjet/monitoring-server package.

  • Start STH with a flag --healtz-port 3030

  • make a GET request to /healthz endpoint (example curl http://localhost:3030/healtz)

  • Will return ok with a status 200 if everything is working well, 500 otherwise.

  • Available flags:

  --healtz-port <healtz-port>              Starts monitoring sever on a selected port
  --healtz-host <healtz-host>              Starts monitoring sever on a specified interface e.g ["0.0.0.0"]. Requires --healtz-port
  --healtz-path <healtz-path>              Exposes monitoring endpoint on specified path. Requires --healtz-port

Clickup Task:
https://app.clickup.com/t/24308805/VDM-1350

Review checks:

These aspects need to be checked by the reviewer:

  • Verify and confirm operation (please post a screenshot)
  • All STH tests pass
  • All Scramjet Cloud Platform tests pass
  • Documentation is updated or no changes

@piotrek6641 piotrek6641 added to verify in progress Assigned person is working on it ready to review labels Aug 31, 2023
@piotrek6641 piotrek6641 changed the title Monitoring Server package + implementation in sth Monitoring Server Aug 31, 2023
@piotrek6641 piotrek6641 requested a review from a-tylenda August 31, 2023 11:39
Copy link
Contributor

@alicja-gruzdz alicja-gruzdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, @piotrek6641 🙌

Could you please also perform a quick memory profiling to verify how much the mem consumption increased after adding another server? I know it's lightweight, but let's measure it.

@patuwwy patuwwy force-pushed the feat/monitoring-server branch from ba3ade6 to 28fe529 Compare September 5, 2023 10:51
Copy link
Contributor

@alicja-gruzdz alicja-gruzdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent

@piotrek6641
Copy link
Contributor Author

piotrek6641 commented Sep 8, 2023

Memory usage

Without montioring server:

image

With monitoring server:

image

Calling endpoint:

image

@patuwwy patuwwy force-pushed the feat/monitoring-server branch 3 times, most recently from 9f292bc to 9f7504a Compare September 11, 2023 09:36
@patuwwy patuwwy added to verify and removed do not merge in progress Assigned person is working on it labels Sep 11, 2023
@patuwwy patuwwy self-requested a review September 11, 2023 12:37
@patuwwy patuwwy force-pushed the feat/monitoring-server branch from 9f7504a to 5373d7e Compare September 12, 2023 11:03
@patuwwy patuwwy force-pushed the feat/monitoring-server branch from 5373d7e to bb61ffd Compare September 12, 2023 14:44
@patuwwy patuwwy force-pushed the feat/monitoring-server branch from ec4dc1f to 30109ee Compare September 13, 2023 10:58
@patuwwy patuwwy force-pushed the feat/monitoring-server branch from 30109ee to bb31f17 Compare September 13, 2023 10:59
Copy link
Contributor

@alicja-gruzdz alicja-gruzdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify ✔️
Screenshot from 2023-09-21 12-36-31

Screenshot from 2023-09-21 12-36-41

@alicja-gruzdz
Copy link
Contributor

Ready to merge.

@patuwwy patuwwy merged commit ce7e004 into devel Sep 25, 2023
@patuwwy patuwwy deleted the feat/monitoring-server branch September 25, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants