Skip to content

Conversation

@piotrek6641
Copy link
Contributor

@piotrek6641 piotrek6641 commented Jul 25, 2023

What:
Finding list of ID's for a sequences with a given name.
Clickup:
https://app.clickup.com/t/24308805/VDM-1298

How to test:

  • si seq deploy packages/forever.tar.gz
  • ts-node packages/cli/src/bin/index.ts sequence list -n @scramjet/js-forever

Review checks:

These aspects need to be checked by the reviewer:

  • Verify and confirm operation (please post a screenshot)
  • All STH tests pass
  • All Scramjet Cloud Platform tests pass
  • Documentation is updated or no changes

@piotrek6641
Copy link
Contributor Author

Needs validation of name when new sequence is being uploaded/ and functionality moved to a different file

@piotrek6641 piotrek6641 marked this pull request as ready for review July 26, 2023 10:34
@piotrek6641 piotrek6641 linked an issue Jul 26, 2023 that may be closed by this pull request
@piotrek6641
Copy link
Contributor Author

This PR doesn't include method to prevent user from sending multiple sequences with the same name as stated in #889 . After discussion with @alicja-gruzdz we currently don't plan to implement this functionality

@alicja-gruzdz
Copy link
Contributor

Then successful it looks great:
Screenshot from 2023-07-28 17-01-51

@alicja-gruzdz
Copy link
Contributor

Then it does not find the Sequence it throws an error which we need to handle:
Screenshot from 2023-07-28 17-03-55

@alicja-gruzdz
Copy link
Contributor

Then it does not find the Sequence it throws an error which we need to handle: Screenshot from 2023-07-28 17-03-55

@piotrek6641 checked it is due to running it with ts-node

@alicja-gruzdz alicja-gruzdz merged commit 5daaf8e into devel Jul 31, 2023
@alicja-gruzdz alicja-gruzdz deleted the feat/getSequenceId branch July 31, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SDK] Add method getSequenceId(seq-name) to HostClient class

4 participants