Remove cpu-features and systeminformation modules #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patuwwy
approved these changes
Jun 1, 2022
MichalCz
force-pushed
the
fix/remove-cpu-features
branch
2 times, most recently
from
d98c638 to
d6ae012
Compare
Member
Author
|
This currently crashes on request for health. I need to fix that. |
MichalCz
force-pushed
the
fix/remove-cpu-features
branch
from
d6ae012 to
2e8c5ba
Compare
MichalCz
force-pushed
the
fix/remove-cpu-features
branch
from
2e8c5ba to
b0c0bdd
Compare
patuwwy
force-pushed
the
fix/remove-cpu-features
branch
2 times, most recently
from
d3d5467 to
f41cc44
Compare
Contributor
|
Rebased |
patuwwy
force-pushed
the
fix/remove-cpu-features
branch
from
f41cc44 to
fe2fbb9
Compare
patuwwy
force-pushed
the
fix/remove-cpu-features
branch
from
edfb8b3 to
10e5f53
Compare
alicja-gruzdz
approved these changes
Jan 11, 2024
Contributor
alicja-gruzdz
left a comment
alicja-gruzdz
left a comment
There was a problem hiding this comment.
excellent, thanks @patuwwy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove dependency on systeminformation.
Why?
Because it was bad.
Usage:
If tests pass, it means it worked - as long as loadcheck does work all is fine.