Skip to content

Conversation

@quinnmil
Copy link
Contributor

@quinnmil quinnmil commented May 6, 2025

Changes

  • Fixes a bug where if the only sampling configuration set was the ignore value, we weren't checking for this in the any_sampling check.
  • Adds a test for this case.

@quinnmil quinnmil linked an issue May 6, 2025 that may be closed by this pull request
@quinnmil quinnmil force-pushed the 811-backwards-compatible-ignore branch from 1145c19 to 5e62200 Compare May 6, 2025 19:46
@quinnmil
Copy link
Contributor Author

quinnmil commented May 6, 2025

Realized that the changes here are redundant. This has already been supported via this:

        self.ignore_endpoints = set(
            config.value("ignore_endpoints") + config.value("ignore")
        )

So we're removing extra logic, but leaving in the new test.

@quinnmil quinnmil force-pushed the 811-backwards-compatible-ignore branch from 5e62200 to c85f0be Compare May 6, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retain backwards compatibility with "ignore" configuration option.

2 participants