test(conftest): make @pytest.mark.bashcomp(cwd=path) relative from test/fixtures
#548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
force-pushed
the
make-bashcomp-cwd-relative
branch
from
1f79fd7 to
f3b1b24
Compare
Collaborator
Author
|
This is blocking #546, so I'd like to have this PR reviewed first. |
akinomyoga
force-pushed
the
make-bashcomp-cwd-relative
branch
from
f3b1b24 to
03219b0
Compare
Collaborator
Author
akinomyoga
force-pushed
the
make-bashcomp-cwd-relative
branch
from
03219b0 to
38107a7
Compare
@pytest.mark.bashcomp(cwd=path), which has been recently added in commit 2ed0e85, had interpreted "cwd" as the relative path to the pytest's working directory. Now this commit makes "cwd" the relative path to the directory "test/fixtures". Note that @pytest.mark.bashcomp(cwd=path) has never been used so far since this is added just for completeness when @pytest.mark.bashcomp(temp_cwd=True) was supported. This will be used for the subsequent commits for the completion of "make".
akinomyoga
force-pushed
the
make-bashcomp-cwd-relative
branch
from
38107a7 to
fa3243e
Compare
scop
approved these changes
Aug 27, 2021
Owner
scop
left a comment
scop
left a comment
There was a problem hiding this comment.
LGTM 👍, sorry about the delay, merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 2ed0e85, I have added
@pytest.mark.bashcomp(cwd=path)along with@pytest.mark.bashcomp(temp_cwd=True), but this has never been used. Now I'd like to use@pytest.mark.bashcomp(cwd=path)intest_make.pyin the updated #546 to specify the directory that contains a staticMakefilefor testing #544. I noticed that it is unuseful thatcwdis the relative path to the current working directory of pytest so would like to change to interpret it as the relative path to thetest/fixtures.