Skip to content

Conversation

@frheault
Copy link
Member

@frheault frheault commented Jan 27, 2025

Quick description

Example PR from StatefulSurface in Dipy (currently under review). Also, transition to Python3.12 since Python3.10 only has 1 year to go before deprecation. (also default on Ubuntu 24.04)

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pep8speaks
Copy link

Hello @frheault, Thank you for submitting the Pull Request !

Line 315:80: E501 line too long (80 > 79 characters)
Line 318:80: E501 line too long (86 > 79 characters)
Line 321:80: E501 line too long (81 > 79 characters)
Line 324:80: E501 line too long (87 > 79 characters)

Line 45:80: E501 line too long (80 > 79 characters)
Line 50:80: E501 line too long (80 > 79 characters)

@arnaudbore arnaudbore changed the title Working test of SFS in Python3.12 [WIP] Working test of SFS in Python3.12 Jun 20, 2025
@frheault
Copy link
Member Author

frheault commented Jul 7, 2025

@arnaudbore Now that SFS is in Dipy, we will wait for their release, BUT should I close this and do a Python3.10 branch?

Or do you want to aim for a Python3.12 release in the fall and my branch could be a start? ;)

@arnaudbore
Copy link
Contributor

@frheault if you can remove update for python 3.12 and focus only on SFS that would be great. You could also create another branch with a python 3.12 focus. If we can include python 3.12 to the list of compatible python versions before merging SFS that would be great.

@frheault frheault closed this Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants