Skip to content

Conversation

@matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Aug 16, 2023

Description

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Backport:
   - PR https://github.com/scikit-hep/pyhf/pull/2277
   - PR https://github.com/scikit-hep/pyhf/pull/2278

@matthewfeickert matthewfeickert added tests pytest fix A bug fix backport Backport PRs from main to release branch labels Aug 16, 2023
@matthewfeickert matthewfeickert self-assigned this Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/v0.7.x@616966d). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/v0.7.x    #2288   +/-   ##
=================================================
  Coverage                  ?   98.23%           
=================================================
  Files                     ?       69           
  Lines                     ?     4540           
  Branches                  ?      802           
=================================================
  Hits                      ?     4460           
  Misses                    ?       47           
  Partials                  ?       33           
Flag Coverage Δ
contrib 27.53% <0.00%> (?)
doctest 61.03% <0.00%> (?)
unittests-3.10 96.27% <0.00%> (?)
unittests-3.11 96.27% <0.00%> (?)
unittests-3.7 96.25% <0.00%> (?)
unittests-3.8 96.29% <0.00%> (?)
unittests-3.9 96.32% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert merged commit dcc6e37 into release/v0.7.x Aug 16, 2023
@matthewfeickert matthewfeickert deleted the backport/fix-minuit-optimizer branch August 16, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backport PRs from main to release branch fix A bug fix tests pytest

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants