Skip to content

Conversation

@matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jun 7, 2023

Description

Ignore URLs for https://indico.desy.de/event/22731 from Sphinx linkcheck tests as the URL
https://indico.desy.de/event/22731/contributions/47953/ is frequently generating 403 Client Error.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Ignore URLs for https://indico.desy.de/event/22731 from Sphinx
  linkcheck tests as the URL
  https://indico.desy.de/event/22731/contributions/47953/ is frequently
  generating 403 Client Error.

* Ignore URLs for https://indico.desy.de/event/22731 from Sphinx
linkcheck tests as the URL
https://indico.desy.de/event/22731/contributions/47953/ is frequently
generating 403 Client Error.
@matthewfeickert matthewfeickert added docs Documentation related tests pytest fix A bug fix need-to-backport tmp label until can be backported to patch release branch labels Jun 7, 2023
@matthewfeickert matthewfeickert self-assigned this Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6bdc501) 98.30% compared to head (843c15b) 98.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2230   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4533     4533           
  Branches      802      802           
=======================================
  Hits         4456     4456           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 97.88% <ø> (ø)
doctest 61.08% <ø> (ø)
unittests-3.10 96.31% <ø> (ø)
unittests-3.11 96.31% <ø> (ø)
unittests-3.8 96.33% <ø> (ø)
unittests-3.9 96.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert matthewfeickert merged commit 233d183 into main Jun 7, 2023
@matthewfeickert matthewfeickert deleted the test/ignore-desy-presentation branch June 7, 2023 17:22
@matthewfeickert matthewfeickert restored the test/ignore-desy-presentation branch June 7, 2023 17:46
@matthewfeickert matthewfeickert deleted the test/ignore-desy-presentation branch June 7, 2023 18:01
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related fix A bug fix tests pytest

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant