Skip to content

fix: Add TYPE_CHECKING guard for numpy.typing #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewfeickert merged 5 commits into from
May 18, 2023
Merged

fix: Add TYPE_CHECKING guard for numpy.typing #2208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1870860
fix: Add TYPE_CHECKING guard for numpy.typing
matthewfeickert May 17, 2023
7e73fae
Add comment
matthewfeickert May 17, 2023
8ca05e5
exclude TYPE_CHECKING from coverage report
matthewfeickert May 17, 2023
7e7b156
Use exclude_also to simplify
matthewfeickert May 17, 2023
771f64d
fix
kratsg May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,9 @@ omit = ["*/pyhf/typing.py"]
precision = 1
sort = "cover"
show_missing = true
exclude_also = [
"if TYPE_CHECKING:"
]

[tool.mypy]
files = "src"
Expand Down
10 changes: 8 additions & 2 deletions src/pyhf/tensor/numpy_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,16 @@
from __future__ import annotations

import logging
from typing import Callable, Generic, Mapping, Sequence, TypeVar, Union
from typing import TYPE_CHECKING, Callable, Generic, Mapping, Sequence, TypeVar, Union

import numpy as np
from numpy.typing import ArrayLike, DTypeLike, NBitBase, NDArray

# Needed while numpy lower bound is older than v1.21.0
if TYPE_CHECKING:
from numpy.typing import ArrayLike, DTypeLike, NBitBase, NDArray
else:
NBitBase = "NBitBase"

from scipy import special
from scipy.special import gammaln, xlogy
from scipy.stats import norm, poisson
Expand Down