Skip to content

Conversation

@matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Aug 28, 2022

Description

Resolves #1907.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Run the publish package workflow on release events when a GitHub release is published.

@matthewfeickert matthewfeickert added CI CI systems, GitHub Actions fix A bug fix labels Aug 28, 2022
@matthewfeickert matthewfeickert self-assigned this Aug 28, 2022
@matthewfeickert matthewfeickert changed the title ci: Run publish to PyPI workflow on release candidate pre-releases ci: Publish to PyPI on release candidate pre-releases Aug 28, 2022
@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #1968 (28c9a0d) into master (afbc4f3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1968   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files          68       68           
  Lines        4377     4377           
  Branches      726      726           
=======================================
  Hits         4300     4300           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 26.57% <ø> (ø)
doctest 60.56% <ø> (ø)
unittests-3.10 96.13% <ø> (ø)
unittests-3.7 96.12% <ø> (ø)
unittests-3.8 96.16% <ø> (ø)
unittests-3.9 96.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@matthewfeickert matthewfeickert changed the title ci: Publish to PyPI on release candidate pre-releases ci: Publish to PyPI on publish of GitHub release Aug 28, 2022
@matthewfeickert matthewfeickert marked this pull request as ready for review August 28, 2022 20:56
@matthewfeickert
Copy link
Member Author

After testing this on a demo project the only issue is that we weren't triggering on releases of any type. I tested this works with both releases and pre-releases, so this should get us v0.7.0rc2.

@matthewfeickert matthewfeickert merged commit 68b99d7 into master Aug 29, 2022
@matthewfeickert matthewfeickert deleted the ci/deploy-pre-releases branch August 29, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI CI systems, GitHub Actions fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pre-release support to publish workflow

1 participant