feat: Add hypotest kwargs to pyhf.infer.intervals.upperlimit

[aryan26roy]

Description

• Resolves Make test statistic configurable in infer.upperlimit #1326
• Resolves pass calculator options through pyhf.infer.upperlimit (toys) #1336

This PR makes the test statistic configurable in intervals/upperlimit by adding a kwarg in the function definition.

Checklist Before Requesting Reviewer

• Tests are passing
• "WIP" removed from the title of the pull request
• Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

• Summarize commit messages into a comprehensive review of the PR

* Add hypotest_kwargs to pyhf.infer.intervals.upperlimit to allow passing in configuration options to the underlying hypotest call
* Add test for hypotest_kwargs use
* Add Aryan Roy to contributor list

[lukasheinrich]

should we maybe rename kwargs into hypotest_kwargs and pass

hypotest(mu, data, model, return_expected_set=True, **hypotest_kwargs)

[matthewfeickert]

The idea being here that this allows for further manipulation of hypotest from upperlimit as desired? Seems to make sense.

[lukasheinrich]

Yeah

[aryan26roy]

@lukasheinrich @matthewfeickert Alright I'll pass the hypotest_kwargs to infer/hypotest directly.

[matthewfeickert]

Thanks @aryan26roy (and sorry for the slow reply — as you can see all of the core devs have been swamped lately). This basically LGTM as the test covers the minimal case and I'm pushing a patch now, but can you also add yourself to the contributors list?

pyhf/CONTRIBUTING.md

Lines 42 to 44 in 7ecaa63

	7. Make sure that you've added your name to `docs/contributors.rst`.
	If you haven't **please** do so by simply appending your name to the bottom of the list.
	We are thankful for and value your contributions to `pyhf`, not matter the size.

[matthewfeickert]

Relevant RTD build: https://pyhf--1613.org.readthedocs.build/en/1613/_generated/pyhf.infer.intervals.upperlimit.html

[matthewfeickert]

I'm going to approve this now, but we should probably get #1622 in first so that we can test that Codecov is properly getting coverage reports even from contributor PRs.

[codecov]

Codecov Report

Merging #1613 (c7a126d) into master (54b44ad) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1613   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files          63       63           
  Lines        4048     4048           
  Branches      576      576           
=======================================
  Hits         3955     3955           
  Misses         54       54           
  Partials       39       39           

Flag	Coverage Δ
contrib	25.44% <100.00%> (ø)
unittests	97.48% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/pyhf/infer/intervals.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b44ad...c7a126d. Read the comment docs.

[matthewfeickert]

Okay PR #1622 is working as intended, so we now have Codecov reporting on contributors PRs. @lukasheinrich @kratsg this should be ready for review now.

[matthewfeickert]

Thanks for the PR @aryan26roy!

[aryan26roy]

@matthewfeickert , glad to be of help!