Skip to content

Precautionary init for OutputChecker #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pllim merged 1 commit into from
Sep 26, 2023
Merged

Precautionary init for OutputChecker #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pytest_doctestplus/output_checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,6 @@ class OutputChecker(doctest.OutputChecker):
r"([0-9]+)L", re.UNICODE)

def __init__(self):
# NOTE OutputChecker is an old-style class with no __init__ method,
# so we can't call the base class version of __init__ here

exp = r'(?:e[+-]?\d+)'

got_floats = (r'\s*([+-]?\d+\.\d*{0}?|'
Expand All @@ -78,6 +75,10 @@ def __init__(self):
fmidend = r'(?<={}){}(?={}|$)'.format(front_sep, want_floats, back_sep)
self.num_want_rgx = re.compile(r'({}|{})'.format(fbeg, fmidend))

# As of 2023-09-26, Python base class has no init, but just in case
# it acquires one.
super().__init__()

def do_fixes(self, want, got):
want = re.sub(self._str_literal_re, r'\1\2', want)
want = re.sub(self._byteorder_re, r'\1\2\3', want)
Expand Down